Change to prefer IPv6 link local address #27981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IPv6 LLA of the Commissioner is almost always valid. On the other hand, Commissioner's ULA updates sometimes don't work well, so it's very rare that there is no ULA. At this time, the Commissioner mDNS resolves IPv6 addresses through Commissionable Node Discovery, - If it selects ULA address, "Network is unreachable" error occurs. - If it selects LLA address, it works well. Through IPv6 source address selection, - If IPv6 destination address is LLA, source address is selected as LLA. - If IPv6 destination address is ULA, source address is selected as ULA. The solution is simple. The Commissioner should prefer IPv6 LLA over ULA among mDNS resolved IPv6 addresses. The same problem occurred on android and darwin platforms, and it is possible that this problem is common to all platforms. So it's better to fix that for all platforms. Signed-off-by: Youngho Yoon <34558998+yhoyoon@users.noreply.github.com>
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
|
@andy31415 to take a peek. |
woody-apple
approved these changes
Jul 18, 2023
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Jul 21, 2023
The IPv6 LLA of the Commissioner is almost always valid. On the other hand, Commissioner's ULA updates sometimes don't work well, so it's very rare that there is no ULA. At this time, the Commissioner mDNS resolves IPv6 addresses through Commissionable Node Discovery, - If it selects ULA address, "Network is unreachable" error occurs. - If it selects LLA address, it works well. Through IPv6 source address selection, - If IPv6 destination address is LLA, source address is selected as LLA. - If IPv6 destination address is ULA, source address is selected as ULA. The solution is simple. The Commissioner should prefer IPv6 LLA over ULA among mDNS resolved IPv6 addresses. The same problem occurred on android and darwin platforms, and it is possible that this problem is common to all platforms. So it's better to fix that for all platforms. Signed-off-by: Youngho Yoon <34558998+yhoyoon@users.noreply.github.com>
jadhavrohit924
pushed a commit
to jadhavrohit924/connectedhomeip
that referenced
this pull request
Aug 14, 2023
The IPv6 LLA of the Commissioner is almost always valid. On the other hand, Commissioner's ULA updates sometimes don't work well, so it's very rare that there is no ULA. At this time, the Commissioner mDNS resolves IPv6 addresses through Commissionable Node Discovery, - If it selects ULA address, "Network is unreachable" error occurs. - If it selects LLA address, it works well. Through IPv6 source address selection, - If IPv6 destination address is LLA, source address is selected as LLA. - If IPv6 destination address is ULA, source address is selected as ULA. The solution is simple. The Commissioner should prefer IPv6 LLA over ULA among mDNS resolved IPv6 addresses. The same problem occurred on android and darwin platforms, and it is possible that this problem is common to all platforms. So it's better to fix that for all platforms. Signed-off-by: Youngho Yoon <34558998+yhoyoon@users.noreply.github.com>
andy31415
pushed a commit
that referenced
this pull request
Aug 21, 2023
The IPv6 LLA of the Commissioner is almost always valid. On the other hand, Commissioner's ULA updates sometimes don't work well, so it's very rare that there is no ULA. At this time, the Commissioner mDNS resolves IPv6 addresses through Commissionable Node Discovery, - If it selects ULA address, "Network is unreachable" error occurs. - If it selects LLA address, it works well. Through IPv6 source address selection, - If IPv6 destination address is LLA, source address is selected as LLA. - If IPv6 destination address is ULA, source address is selected as ULA. The solution is simple. The Commissioner should prefer IPv6 LLA over ULA among mDNS resolved IPv6 addresses. The same problem occurred on android and darwin platforms, and it is possible that this problem is common to all platforms. So it's better to fix that for all platforms. Signed-off-by: Youngho Yoon <34558998+yhoyoon@users.noreply.github.com> Co-authored-by: Youngho Yoon <34558998+yhoyoon@users.noreply.github.com>
yhoyoon
added a commit
to yhoyoon/connectedhomeip
that referenced
this pull request
Aug 28, 2023
The project-chip#27981 PR was merged, but it didn't follow IpScore's comments. // IP addess "suitability" // - Larger value means "more suitable" // - Enum ordered ascending for easier read. Note however that order of // checks MUST match in ScoreIpAddress below. enum class IpScore : unsigned This change matches the order of ScoreIpAddress with the order of IpScore enum. Signed-off-by: Youngho Yoon <34558998+yhoyoon@users.noreply.github.com>
yhoyoon
added a commit
to yhoyoon/connectedhomeip
that referenced
this pull request
Aug 29, 2023
The project-chip#27981 PR was merged, but it didn't follow IpScore's comments. // IP addess "suitability" // - Larger value means "more suitable" // - Enum ordered ascending for easier read. Note however that order of // checks MUST match in ScoreIpAddress below. enum class IpScore : unsigned This change matches the order of ScoreIpAddress with the order of IpScore enum. Signed-off-by: Youngho Yoon <34558998+yhoyoon@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Aug 29, 2023
The #27981 PR was merged, but it didn't follow IpScore's comments. // IP addess "suitability" // - Larger value means "more suitable" // - Enum ordered ascending for easier read. Note however that order of // checks MUST match in ScoreIpAddress below. enum class IpScore : unsigned This change matches the order of ScoreIpAddress with the order of IpScore enum. Signed-off-by: Youngho Yoon <34558998+yhoyoon@users.noreply.github.com>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
The project-chip#27981 PR was merged, but it didn't follow IpScore's comments. // IP addess "suitability" // - Larger value means "more suitable" // - Enum ordered ascending for easier read. Note however that order of // checks MUST match in ScoreIpAddress below. enum class IpScore : unsigned This change matches the order of ScoreIpAddress with the order of IpScore enum. Signed-off-by: Youngho Yoon <34558998+yhoyoon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IPv6 LLA of the Commissioner is almost always valid. On the other hand, Commissioner's ULA updates sometimes don't work well, so it's very rare that there is no ULA.
At this time, the Commissioner mDNS resolves IPv6 addresses through Commissionable Node Discovery,
Through IPv6 source address selection,
The solution is simple. The Commissioner should prefer IPv6 LLA over ULA among mDNS resolved IPv6 addresses. The same problem occurred on android and darwin platforms, and it is possible that this problem is common to all platforms. So it's better to fix that for all platforms.