-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time sync: TSC feature #28418
Merged
mergify
merged 14 commits into
project-chip:master
from
cecille:time_sync_trusted_time_source
Aug 21, 2023
Merged
Time sync: TSC feature #28418
mergify
merged 14 commits into
project-chip:master
from
cecille:time_sync_trusted_time_source
Aug 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecille
force-pushed
the
time_sync_trusted_time_source
branch
from
July 31, 2023 19:29
744b185
to
10de90e
Compare
PR #28418: Size comparison from 521eb16 to 744b185 Increases (2 builds for bl602, cc32xx)
Decreases (3 builds for bl602, bl702)
Full report (12 builds for bl602, bl702, bl702l, cc32xx, k32w, mbed, qpg)
|
PR #28418: Size comparison from 521eb16 to 10de90e Increases above 0.2%:
Increases (25 builds for bl702l, cc32xx, cyw30739, linux, nrfconnect, psoc6, telink)
Decreases (14 builds for bl702, cc32xx, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
- make delegates async and combine - move define into build file - read granularity from device
cecille
changed the title
DNS: Early draft of time sync TSC feature
Time sync: TSC feature
Aug 11, 2023
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple and
carol-apple
August 11, 2023 18:43
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 11, 2023 18:43
PR #28418: Size comparison from 3c3e5f5 to 0ef1cab Increases above 0.2%:
Increases (28 builds for bl602, cc32xx, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (11 builds for bl702, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Aug 17, 2023
cecille
commented
Aug 21, 2023
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Outdated
Show resolved
Hide resolved
aronrosenberg
approved these changes
Aug 21, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
* DNS: Early draft of time sync TSC feature * Address TODOs - make delegates async and combine - move define into build file - read granularity from device * Add test to CI * Restyled by whitespace * Restyled by gn * Restyled by isort * Linty linter * more lint * lint trap cleanout * what's going on with the exit of the repl? * Shell processes never say die. * Remove a stale todo * Update src/app/clusters/time-synchronization-server/time-synchronization-server.cpp --------- Co-authored-by: Restyled.io <commits@restyled.io>
src/app/clusters/time-synchronization-server/time-synchronization-delegate.h
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-delegate.h
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.h
Show resolved
Hide resolved
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* DNS: Early draft of time sync TSC feature * Address TODOs - make delegates async and combine - move define into build file - read granularity from device * Add test to CI * Restyled by whitespace * Restyled by gn * Restyled by isort * Linty linter * more lint * lint trap cleanout * what's going on with the exit of the repl? * Shell processes never say die. * Remove a stale todo * Update src/app/clusters/time-synchronization-server/time-synchronization-server.cpp --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the time sync client, which allows devices to reach out to other matter nodes to query time.
Because this feature is challenging to test in the CI, this PR also includes a runtime options provider implementation that allows the time cluster to fake having no system time, forcing a read out over the network.
Tests: The added tests MUST be run using the provided script runner because they require a specific network and app setup to work correctly. The first two tests are used to prove the platform time bypass is functional (test_SimulateNoInternalTime and test_HaveInternalTime). The next "test" sets up a second node to act as the trusted time source. test_SetAndReadFromTrustedTimeSource tests that the node can read from the trusted time source immediately after setting it up. test_ReadFromTrustedTimeSource tests that the values persist correct and the node can read from the trusted time source after reboot.
This PR also includes an expansion of the delegate API, which will allow platforms to supply their own time. Currently, this is done using the platform time abstractions to match the current style of the time sync server impl.
Setting gn arg time_sync_enable_tsc_feature to 0 will turn this feature off. Note that this does NOT control the zap feature map.
Fixes: #28271