Bugfix using CHIP_CONFIG_SECURITY_TEST_MODE will not allow to build. #28638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bzbarsky-apple
requested changes
Aug 10, 2023
|
PR #28638: Size comparison from 7353fd6 to 1eaa662 Increases (1 build for bl702l)
Decreases (5 builds for bl602, bl702, cc32xx, nrfconnect)
Full report (12 builds for bl602, bl702, bl702l, cc32xx, mbed, nrfconnect, qpg)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #28638: Size comparison from 95e3d94 to 4ca6226 Increases (10 builds for bl602, bl702, psoc6, telink)
Decreases (6 builds for efr32, esp32, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Aug 11, 2023
jmartinez-silabs
requested changes
Aug 11, 2023
There was a problem hiding this comment.
This should probably be gated with a #ifdef on the API version of open thread to not break platform that would use an older thread version. It is done a few time in the GenericThread files
Edit**
I looked it up, this new API changed with version OPENTHREAD_API_VERSION (160)
https://github.com/openthread/openthread/pull/6862/files#diff-67e8f8a8f8f67e317379f96d198f1bb77a23ffa2b9a3f4fafebb4c1317c4fcd2
so wrap new call in#if OPENTHREAD_API_VERSION >= 160 and #else keep the old call
|
@jmartinez-silabs In view of this #28058 there's probably no need for the API version check? |
Sarthak-Shaha
force-pushed
the
bugfix/security_test_mode
branch
from
4ca6226
to
059d571
Compare
|
@selissia Yes we can ignore that. I didn't realize that it has been broken for so long. The other comment needs to be addressed still. |
…s.cpp to follow the appropriate API call
Sarthak-Shaha
force-pushed
the
bugfix/security_test_mode
branch
from
dac362d
to
8c3b603
Compare
jmartinez-silabs
approved these changes
Aug 11, 2023
|
PR #28638: Size comparison from 9a35c44 to 8c3b603 Increases (14 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, psoc6, telink)
Decreases (5 builds for telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
selissia
approved these changes
Aug 11, 2023
bzbarsky-apple
approved these changes
Aug 12, 2023
|
PR #28638: Size comparison from d928f3c to 87a1bf0 Increases (6 builds for nrfconnect, telink)
Decreases (15 builds for bl602, bl702, cc32xx, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #28638: Size comparison from bd2985f to 74f4bdb Increases (9 builds for bl702, bl702l, psoc6, telink)
Decreases (11 builds for bl602, cc32xx, efr32, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #28638: Size comparison from 7067897 to d389106 Increases (6 builds for bl602, psoc6, telink)
Decreases (9 builds for cc32xx, efr32, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
s07641069
pushed a commit
to s07641069/connectedhomeip
that referenced
this pull request
Aug 22, 2023
…s.cpp to follow the appropriate API call (project-chip#28638)
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…s.cpp to follow the appropriate API call (project-chip#28638)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
void otThreadGetNetworkKey(otInstance *aInstance, otNetworkKey *aNetworkKey);