-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] encrypted_ota: Call abort API when aborting OTA and some refactoring #28778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamdp
force-pushed
the
esp32_encrypt_ota
branch
from
August 21, 2023 13:01
76276c8
to
484bfde
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
August 21, 2023 13:02
pullapprove
bot
requested review from
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 21, 2023 13:02
PR #28778: Size comparison from 747c6c3 to 484bfde Increases (13 builds for cyw30739, esp32, k32w, nrfconnect, psoc6, telink)
Decreases (12 builds for bl702, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shubhamdp
force-pushed
the
esp32_encrypt_ota
branch
from
August 22, 2023 05:06
484bfde
to
2c6851c
Compare
PR #28778: Size comparison from 270d8e2 to 2c6851c Increases (6 builds for bl602, cyw30739, esp32, telink)
Decreases (10 builds for bl602, bl702, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jadhavrohit924
approved these changes
Aug 22, 2023
hmalpani
reviewed
Aug 22, 2023
PR #28778: Size comparison from 270d8e2 to 63d9da0 Increases above 0.2%:
Increases (30 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (50 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
wqx6
approved these changes
Aug 23, 2023
shubhamdp
force-pushed
the
esp32_encrypt_ota
branch
from
August 24, 2023 12:48
866d71d
to
74d222b
Compare
PR #28778: Size comparison from 18d3ef4 to 74d222b Increases (1 build for bl702l)
Decreases (1 build for efr32)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
selissia
approved these changes
Aug 24, 2023
dhrishi
approved these changes
Aug 25, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
…ctoring (project-chip#28778) * [ESP32] encrypted_ota: Call abort API when aborting and some refactoring * Make DecryptEnd return an error and honour it * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…ctoring (project-chip#28778) * [ESP32] encrypted_ota: Call abort API when aborting and some refactoring * Make DecryptEnd return an error and honour it * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem and change overview
esp_encrypted_img_decrypt_abort()
API is recently added to the encrypted ota component, so using it when aborting the OTA process.Also, refactored out the decryption bits into routines.
Tests