-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match Media Playback Cluster
to spec
#30217
Merged
andy31415
merged 5 commits into
project-chip:master
from
andy31415:media_playback_to_spec
Nov 6, 2023
Merged
Match Media Playback Cluster
to spec
#30217
andy31415
merged 5 commits into
project-chip:master
from
andy31415:media_playback_to_spec
Nov 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
added
Spec XML align
SDK XML does not match the spec (including naming, etc)
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
labels
Nov 3, 2023
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
kpschoedel
November 3, 2023 20:58
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
November 3, 2023 20:58
pullapprove
bot
added
review - pending
examples
darwin
controller
app
and removed
examples
darwin
controller
app
labels
Nov 3, 2023
PR #30217: Size comparison from 754a938 to 9ebdaf4 Increases (8 builds for bl702, bl702l, cc32xx)
Decreases (13 builds for bl702, bl702l, cc32xx, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 4, 2023
PR #30217: Size comparison from 754a938 to 85c6297 Increases (9 builds for bl702, bl702l, cc32xx, psoc6)
Decreases (13 builds for bl702, bl702l, cc32xx, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
pushed a commit
to andy31415/connectedhomeip
that referenced
this pull request
Nov 7, 2023
andy31415
added a commit
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
examples
fast track
review - pending
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
Spec XML align
SDK XML does not match the spec (including naming, etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: