-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TV Matter Media: Updated the existing clusters & Added 2 new clusters according to the latest Matter 1.3 spec. (Account Login, Channel, Content Launcher, Media Playback, Target Navigator, Content App Observer and Content Control) #30691
TV Matter Media: Updated the existing clusters & Added 2 new clusters according to the latest Matter 1.3 spec. (Account Login, Channel, Content Launcher, Media Playback, Target Navigator, Content App Observer and Content Control) #30691
Conversation
PR #30691: Size comparison from f94a44e to 22e5532 Full report (31 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, k32w, linux, mbed, qpg)
|
@lazarkov what is the spec version that we are comparing against? If I use ToT scraper data I get a lot of diffs like |
12c3399
to
b0c8b9a
Compare
PR #30691: Size comparison from ba504e3 to b0c8b9a Increases (1 build for linux)
Decreases (1 build for linux)
Full report (31 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, k32w, linux, mbed, qpg)
|
@andy31415 I believe there's no difference visible as I haven't posted the zap generated files. This is currently marked as draft, once I add zap files, it should match the sdk templates. btw, I haven't posted zap generated files on purpose as they for initial review I think it's easier to understand what's going on. |
99430b9
to
ffe5078
Compare
PR #30691: Size comparison from b379158 to 4ba5630 Increases above 0.2%:
Increases (4 builds for cc13x4_26x4, linux)
Decreases (1 build for linux)
Full report (27 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, mbed, qpg)
|
4ba5630
to
7c5ef8a
Compare
PR #30691: Size comparison from 5269ad2 to c6e1d05 Increases above 0.2%:
Increases (29 builds for cc13x4_26x4, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (1 build for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
3c9d635
to
41a1aa8
Compare
PR #30691: Size comparison from b8c5af5 to 41a1aa8 Increases above 0.2%:
Increases (29 builds for cc13x4_26x4, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (1 build for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30691: Size comparison from b8c5af5 to 02f75f8 Increases above 0.2%:
Increases (29 builds for cc13x4_26x4, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (1 build for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30691: Size comparison from d823ea2 to 7389438 Increases above 0.2%:
Increases (11 builds for cc13x4_26x4, cyw30739, esp32, linux, nrfconnect, psoc6)
Decreases (1 build for linux)
Full report (40 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
7389438
to
a196604
Compare
PR #30691: Size comparison from d823ea2 to 58e69d3 Increases above 0.2%:
Increases (29 builds for cc13x4_26x4, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (1 build for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
58e69d3
to
0ac0b77
Compare
PR #30691: Size comparison from f6e2cfc to 0ac0b77 Increases above 0.2%:
Increases (29 builds for cc13x4_26x4, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (1 build for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
0ac0b77
to
145b6e0
Compare
PR #30691: Size comparison from 223c054 to 145b6e0 Increases above 0.2%:
Increases (9 builds for cc13x4_26x4, cyw30739, linux, nrfconnect, psoc6)
Decreases (1 build for linux)
Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
145b6e0
to
3f73cca
Compare
PR #30691: Size comparison from 223c054 to 3f73cca Increases above 0.2%:
Increases (29 builds for cc13x4_26x4, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (2 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
The existing clusters that have been updated are: Account Login, Channel, Content Launcher, Media Playback and Target Navigator. I have also added 2 new Clusters: Content Control and Content app observer
3f73cca
to
b5c5671
Compare
PR #30691: Size comparison from d9b2f5b to b5c5671 Increases above 0.2%:
Increases (29 builds for cc13x4_26x4, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (2 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
to fix build broken due to project-chip#30691
to fix build broken due to #30691
The existing clusters that have been updated are: Account Login, Channel, Content Launcher, Media Playback and Target Navigator
Problem
Change overview
Tests
Build the TV app using command:
scripts/examples/gn_build_example.sh examples/tv-app/linux out/debug/
Built the CHIP tool test client using command:
scripts/examples/gn_build_example.sh examples/chip-tool out/debug/ chip_config_network_layer_ble=false
Run tests using command:
./scripts/run_in_build_env.sh \ "./scripts/tests/run_test_suite.py \ --runner chip_tool_python \ --chip-tool ./out/debug/chip-tool \ run \ --iterations 1 \ --test-timeout-seconds 120 \ --tv-app ./out/debug/chip-tv-app \ "