-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TC-DA-1.2: cover PAI incorrect PID encoding #32717
Merged
mergify
merged 3 commits into
project-chip:master
from
cecille:tc_da_1_2_cover_PAI_incorrect_PID_encoding
Apr 17, 2024
Merged
TC-DA-1.2: cover PAI incorrect PID encoding #32717
mergify
merged 3 commits into
project-chip:master
from
cecille:tc_da_1_2_cover_PAI_incorrect_PID_encoding
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #32717: Size comparison from aa9f8e5 to 30d3224 Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
This wasn't here before. I want to see this fail before adding the fix.
Also, apparently the formatting rules changed. OK...
cecille
force-pushed
the
tc_da_1_2_cover_PAI_incorrect_PID_encoding
branch
from
April 12, 2024 14:12
3915a76
to
de0183f
Compare
PR #32717: Size comparison from 4be45dd to de0183f Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
April 12, 2024 18:05
pullapprove
bot
requested review from
LuDuda,
mhazley,
mkardous-silabs,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
April 12, 2024 18:05
tcarmelveilleux
approved these changes
Apr 15, 2024
jmeg-sfy
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was changed in
#28911, but the cert test still allows this.
Brief explanation: The PAI does not NEED to contain the PID. However, the spec was recently updated to indicate that if the PAI attempts to encode the PID and does it incorrectly, the cert is invalid. So this is adding an explicit check for that condition.
TEST: please see included test-testing script that runs though the test with various cert combinations. Test vectors were updated in #28911, test-testing test now passes fully and is added to the CI.