Expose rs-matter's lib as matter_rs
#108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Then `s/rs-matter::/matter_rs::/g`.
MabezDev
force-pushed
the
expose-as-matter-rs
branch
from
5bb6584
to
8156f4b
Compare
|
I personally find the crate name different from the lib really, really confusing. That's why we changed the name of the lib to |
|
... and there is already a crate named |
Closed
|
As discussed in the meeting, opting to keep the same name for the crate and the library, closing this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Then
s/rs-matter::/matter_rs::/g.Whilst we can't have the crates.io name, we can still have the library name if we want.
I'm not that bothered either way, but I thought I'd open it as a suggestion.