Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #60 #61

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Fix #60 #61

merged 1 commit into from
Jul 1, 2023

Conversation

ivmarkov
Copy link
Contributor

@ivmarkov ivmarkov commented Jun 30, 2023 •
edited
Loading

Subject says it all.

I have forgotten a few [cfg()]s that were done the old feature= based way, before our auto-selection of an mDNS provider based on the underlying OS got active.

Tested on x86 Mac with a Google Controller.

@ivmarkov ivmarkov mentioned this pull request Jun 30, 2023
Merged
@ivmarkov
Copy link
Contributor Author

@kedars Restyler complains on async functions. Have never used it, but the error message seems to imply that Restyler is running in CI with Rust 2015 compatibility. I think we need to update it to at least 2018, if not 2021.

@ivmarkov ivmarkov mentioned this pull request Jun 30, 2023
Closed
@kedars kedars merged commit aa6aa47 into project-chip:no_std Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kedars kedars kedars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivmarkov @kedars