Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Unify code generation diff check #1416

Merged

Conversation

dhchandw
Copy link
Collaborator

@dhchandw dhchandw commented Sep 3, 2024

Added Unify code generation diff check job:

  • Clones the Unify SDK
  • Regenerates all the ZAP generated files using working branch of ZAP
  • Checks for git diff (fails if there is a diff)

@dhchandw dhchandw marked this pull request as ready for review September 3, 2024 19:42
@dhchandw dhchandw force-pushed the task/unifyDiffCheck/ZAPP-1441 branch from 9ad9f36 to ec83e62 Compare September 3, 2024 20:36
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.70%. Comparing base (efae34c) to head (ec83e62).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1416      +/-   ##
==========================================
- Coverage   66.86%   66.70%   -0.16%     
==========================================
  Files         191      193       +2     
  Lines       20689    20852     +163     
  Branches     4532     4572      +40     
==========================================
+ Hits        13834    13910      +76     
- Misses       6855     6942      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhchandw dhchandw force-pushed the task/unifyDiffCheck/ZAPP-1441 branch 2 times, most recently from c6e038a to f318253 Compare September 4, 2024 13:49
@dhchandw dhchandw force-pushed the task/unifyDiffCheck/ZAPP-1441 branch from 17e84fc to 90b8da4 Compare September 4, 2024 18:26
@dhchandw dhchandw merged commit e26dcfe into project-chip:master Sep 4, 2024
14 checks passed
@dhchandw dhchandw deleted the task/unifyDiffCheck/ZAPP-1441 branch October 10, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants