Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow version stamp skipping and local pkg install. #876

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

tecimovic
Copy link
Collaborator

  • Add temporary target used to test with local fork of pkg.
  • Honor ZAP_SKIP_REAL_VERSION environment variable.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@fedcdb4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #876   +/-   ##
=========================================
  Coverage          ?   67.64%           
=========================================
  Files             ?      147           
  Lines             ?    14846           
  Branches          ?     3378           
=========================================
  Hits              ?    10042           
  Misses            ?     4194           
  Partials          ?      610           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Dec 21, 2022
It's 4-5x faster for me this way.

Also sets ZAP_SKIP_REAL_VERSION so that once
project-chip/zap#876 merges we stop messing with the ZAP
repo just to run it.
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Dec 22, 2022
It's 4-5x faster for me this way.

Also sets ZAP_SKIP_REAL_VERSION so that once
project-chip/zap#876 merges we stop messing with the ZAP
repo just to run it.
Damian-Nordic pushed a commit to project-chip/connectedhomeip that referenced this pull request Dec 22, 2022
It's 4-5x faster for me this way.

Also sets ZAP_SKIP_REAL_VERSION so that once
project-chip/zap#876 merges we stop messing with the ZAP
repo just to run it.
@tecimovic tecimovic merged commit d785a5b into project-chip:master Jan 4, 2023
@tecimovic tecimovic deleted the more-cleanup branch January 20, 2023 14:04
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this pull request Mar 15, 2023
It's 4-5x faster for me this way.

Also sets ZAP_SKIP_REAL_VERSION so that once
project-chip/zap#876 merges we stop messing with the ZAP
repo just to run it.
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this pull request Mar 15, 2023
It's 4-5x faster for me this way.

Also sets ZAP_SKIP_REAL_VERSION so that once
project-chip/zap#876 merges we stop messing with the ZAP
repo just to run it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants