Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functional tests #193

Conversation

abhijeet-dhumal
Copy link
Contributor

@abhijeet-dhumal abhijeet-dhumal commented Jan 4, 2024

Issue link

Implement functional tests for Instascale

Define use cases for Instascale
Implement functional tests covering Instascale use cases
Implement GitHub PR check running InstaScale functional tests

What changes have been made

Added functional test to define use cases for instascale to interact with appwrapper-reconciler loop using envtest control plane. ~ Guided by - @sutaakar

Verification steps

  • Verify setup-envtest package to run controller specific test in local control plane.
  • Verify that test is able to create an appwrapper in local control plane cluster.
  • Verify that InstaScale adds finalizer into AppWrapper.
  • Verify that InstaScale scaled MachineSet to spin up expected number of machines. Verify that InstaScale scales down MachineSet when AppWrapper is finished.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@abhijeet-dhumal abhijeet-dhumal changed the title Add functional tests Add functional test Jan 4, 2024
@abhijeet-dhumal abhijeet-dhumal force-pushed the add-functional-tests branch 2 times, most recently from 79b0817 to 9af41f9 Compare January 4, 2024 12:43
@abhijeet-dhumal abhijeet-dhumal changed the title Add functional test Add functional tests Jan 5, 2024
@abhijeet-dhumal abhijeet-dhumal force-pushed the add-functional-tests branch 7 times, most recently from 93f9940 to d478f6b Compare January 16, 2024 06:50
@abhijeet-dhumal abhijeet-dhumal force-pushed the add-functional-tests branch 2 times, most recently from 6347020 to 3a364ed Compare January 18, 2024 08:11
Copy link
Contributor

@VanillaSpoon VanillaSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @abhijeet-dhumal
Great work!

functional-tests/appwrapper_reconciler_test.go Outdated Show resolved Hide resolved
.github/workflows/functional-test.yml Show resolved Hide resolved
functional-tests/appwrapper_reconciler_test.go Outdated Show resolved Hide resolved
@abhijeet-dhumal abhijeet-dhumal force-pushed the add-functional-tests branch 4 times, most recently from e04f238 to 3b0b6c8 Compare January 19, 2024 10:48
@abhijeet-dhumal abhijeet-dhumal force-pushed the add-functional-tests branch 3 times, most recently from f2ea314 to 770e0f2 Compare January 30, 2024 10:51
… with using envtest control plane or using existing-cluster
Copy link
Contributor

@VanillaSpoon VanillaSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this @abhijeet-dhumal, great job :)
\lgtm

Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ff324ea into project-codeflare:main Jan 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants