-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functional tests #193
Add functional tests #193
Conversation
79b0817
to
9af41f9
Compare
93f9940
to
d478f6b
Compare
6347020
to
3a364ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @abhijeet-dhumal
Great work!
e04f238
to
3b0b6c8
Compare
a824d72
to
3f967af
Compare
3f967af
to
2538498
Compare
2538498
to
688f744
Compare
f0c6968
to
3351b97
Compare
f2ea314
to
770e0f2
Compare
770e0f2
to
1a97866
Compare
… with using envtest control plane or using existing-cluster
1a97866
to
115a6b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this @abhijeet-dhumal, great job :)
\lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ff324ea
into
project-codeflare:main
Issue link
Implement functional tests for Instascale
What changes have been made
Added functional test to define use cases for instascale to interact with appwrapper-reconciler loop using envtest control plane. ~ Guided by - @sutaakar
Verification steps
Checks