Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup kubebuilder to run functional-tests in release workflow #200

Conversation

ChristianZaccaria
Copy link
Contributor

Issue link

What changes have been made

The instascale-release.yml workflow is running all tests including the functional-tests ones without performing any setup for it: https://github.com/project-codeflare/instascale/blob/main/.github/workflows/instascale-release.yml#L54

We can see in the functional-test workflow that the steps for downloading kubebuilder and setting it up is necessary before running the functional-tests, for that reason it is failing. We could probably add the above highlighted fields in our release workflow and it should pass.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@sutaakar
Copy link
Contributor

I think it may be enough to change Test step to run go test -v ./controllers.
The functional tests are executed for PR check when dependencies are upgraded, I think it is not necessary to run the test twice.

@sutaakar
Copy link
Contributor

Or maybe to drop tests from release workflow completely, to rely on PR check.

Copy link

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 21424f0 into project-codeflare:main Feb 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants