Setup kubebuilder to run functional-tests in release workflow #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
What changes have been made
The
instascale-release.yml
workflow is running all tests including the functional-tests ones without performing any setup for it: https://github.com/project-codeflare/instascale/blob/main/.github/workflows/instascale-release.yml#L54We can see in the functional-test workflow that the steps for downloading kubebuilder and setting it up is necessary before running the functional-tests, for that reason it is failing. We could probably add the above highlighted fields in our release workflow and it should pass.
Verification steps
Checks