Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust release workflow to update MCAD on funtional test #201

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Feb 21, 2024

Issue link

N/A

What changes have been made

Adding sed replacement for MCAD dependency version in appwrapper_reconciler_test.go.

Verification steps

To be verified in release workflow.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work there! Just left a few nitpicks, thank you.

.github/workflows/instascale-release.yml Show resolved Hide resolved
.github/workflows/instascale-release.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 21, 2024
@sutaakar
Copy link
Contributor Author

/approve

Copy link

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChristianZaccaria, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ca8c03f into project-codeflare:main Feb 21, 2024
3 checks passed
@sutaakar sutaakar deleted the release branch February 21, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants