Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notifications): do not crash on missing notificationIcon #1118

Merged
merged 1 commit into from
Jan 13, 2024
Merged

fix(notifications): do not crash on missing notificationIcon #1118

merged 1 commit into from
Jan 13, 2024

Conversation

antonstjernquist
Copy link
Contributor

Pull Request Description

  • Avoid crash on missing NotificationIcon
  • Add error for missing app, due to incorrect id / not initialised app
  • Add warning on missing notification icon

Pull Request Checklist:

  • Have you followed the guidelines in our Contributing document and Code of Conduct?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you built and tested NPWD in-game after the relevant change?

itschip
itschip approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@itschip itschip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itschip itschip merged commit b5d59e4 into project-error:master Jan 13, 2024
4 checks passed
antonstjernquist added a commit to antonstjernquist/npwd that referenced this pull request Jan 26, 2024
@antonstjernquist
fix(notifications): do not crash on missing notificationIcon (project…
5850b1f 
…-error#1118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itschip itschip itschip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonstjernquist @itschip