Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable walking when an inputfield is focused #234

Merged
merged 4 commits into from
May 24, 2021
Merged

Disable walking when an inputfield is focused #234

merged 4 commits into from
May 24, 2021

Conversation

NuttyShrimp
Copy link
Contributor

resolves #227

jfrader
jfrader approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@jfrader jfrader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

Just a thought, can you rename "bool" to something more meaningful?

Thanks for your contribution!

@NuttyShrimp
refactor(phone) renamed var & replaced copy paste code
89f3949 
Instead of copying the code it now uses a custom hook
jfrader
jfrader suggested changes May 21, 2021
View reviewed changes
Copy link
Contributor

@jfrader jfrader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found some possible improvements, do you mind adjusting that?

phone/src/ui/components/Input.tsx Outdated Show resolved Hide resolved
phone/src/ui/components/Input.tsx Outdated Show resolved Hide resolved
phone/src/ui/components/Input.tsx Outdated Show resolved Hide resolved
phone/src/ui/components/Input.tsx Outdated Show resolved Hide resolved
phone/src/ui/components/Input.tsx Outdated Show resolved Hide resolved
@RockySouthpaw
Copy link
Contributor

I’ll test this in roughly 12 hours.

@RockySouthpaw RockySouthpaw added Awaiting Code Review Awaiting code review. Awaiting Testing Awaiting in-game testing. labels May 21, 2021
@NuttyShrimp
Copy link
Contributor Author

Just found some possible improvements, do you mind adjusting that?

I'll push them during the day, thanks for the feedback!

RockySouthpaw
RockySouthpaw approved these changes May 22, 2021
View reviewed changes
Copy link
Contributor

@RockySouthpaw RockySouthpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well.

Thank you for the PR :). Will let taso or chip review it too before merging.

TasoOneAsia
TasoOneAsia requested changes May 24, 2021
View reviewed changes
Copy link
Contributor

@TasoOneAsia TasoOneAsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from a couple things.

resources/client/cl_main.ts Outdated Show resolved Hide resolved
phone/src/ui/components/Input.tsx Outdated Show resolved Hide resolved
@RockySouthpaw
Copy link
Contributor

Changes were applied so going to merge this

@RockySouthpaw RockySouthpaw merged commit 870aeda into project-error:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TasoOneAsia TasoOneAsia TasoOneAsia requested changes

@RockySouthpaw RockySouthpaw RockySouthpaw approved these changes

@jfrader jfrader jfrader approved these changes

@itschip itschip Awaiting requested review from itschip

Assignees
No one assigned
Labels
Awaiting Code Review Awaiting code review. Awaiting Testing Awaiting in-game testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: While using text fields, controls are enabled so movement occurs/menus open.
4 participants
@NuttyShrimp @RockySouthpaw @jfrader @TasoOneAsia