refactor, added fxmanifest stubs, added lua support #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itschip
reviewed
Apr 10, 2021
| import fs from "fs"; | ||
|
|
||
| export const copyFiles = (resourcePath: string): void => { | ||
| // lua does not need to copy any files |
There was a problem hiding this comment.
Do we really need this file at all?
There was a problem hiding this comment.
on paper, no. But if we delete it we have to do some annoying "does file exists" check right here: https://github.com/itschip/create-fivem-app/pull/3/files#diff-829eff2e0611772913dffeeae499783591e9b75b26b22b4d7d7283e06cf8e656R30
And I think that might be uglier than just having this empty file :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\n\nright in the file is rather ugly. This is a bit more maintainablesprintf-jsto parse some strings nicely, as an example here I have added thenameinformation to all the manifest filescreateEssentialsandinstallTemplateto allow for more languages easier and made specific files for their "copiers" and "creators". This format should probably be the first step in allowing unique(r) template support for cfa, for example how the vue-cli works.I have also added Lua support, it is very basic and cfa automatically generates all files for it, as there isn't really packages for it.