Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowSpectateFreeCam config option #74

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

zhliau
Copy link
Contributor

@zhliau zhliau commented Aug 9, 2024

Works in conjunction with project-fika/Fika-Plugin#131 to allow server-side control of the spectator freecam on death/extract.

@Lacyway
Copy link
Member

Lacyway commented Aug 9, 2024

Is this ready for review? You've labelled it as a draft. Also, please DM me on Discord.

@zhliau
Copy link
Contributor Author

zhliau commented Aug 9, 2024

Is this ready for review? You've labelled it as a draft. Also, please DM me on Discord.

I wanted to do more testing with the plugin PR before merging this one, specifically I need to test with more than 2 players and make sure the cam jumps appropriately. I sent you a friend request in Discord as #zedramus since it seems you aren't allowing DMs.

@zhliau zhliau marked this pull request as ready for review August 9, 2024 17:49
@zhliau
Copy link
Contributor Author

zhliau commented Aug 9, 2024

Just tested the plugin changes out, seems good to go! There are some minor improvements I think I can make later such as having the spectate cam not follow the extracted user up into space, but I'll work on that later.

@Lacyway Lacyway merged commit b8322fd into project-fika:main Aug 11, 2024
3ohne pushed a commit to 3ohne/Fika-Server that referenced this pull request Oct 22, 2024
…-item-if-active

Check if quest item is Active and Enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants