Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4534] Support filtering with multiple values #4846

Merged

Conversation

samdoran
Copy link
Contributor

Jira Ticket

COST-4534

Description

Support multiple filter values for the project and group fields on the cost groups API

Testing

curl "http://localhost:8000/api/cost-management/v1/settings/cost-groups/?limit=100&filter%5Bdefault%5D=false&filter%5Bproject%5D=test&filter%5Bproject%5D=cost"

@samdoran samdoran added the smoke-tests pr_check will build the image and run minimal required smokes label Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Merging #4846 (685cd2c) into main (ef98d21) will not change coverage.
The diff coverage is 100.0%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4846   +/-   ##
=====================================
  Coverage   94.0%   94.0%           
=====================================
  Files        365     365           
  Lines      30288   30288           
  Branches    3603    3603           
=====================================
  Hits       28463   28463           
  Misses      1162    1162           
  Partials     663     663           

@samdoran samdoran force-pushed the COST-3394/COST-4534-support-multiple-filters-per-field branch from c4e4525 to 891c5f6 Compare January 3, 2024 21:26
@samdoran samdoran marked this pull request as ready for review January 3, 2024 22:10
@samdoran samdoran requested review from a team as code owners January 3, 2024 22:10
@samdoran samdoran force-pushed the COST-3394/COST-4534-support-multiple-filters-per-field branch from 891c5f6 to 0168225 Compare January 3, 2024 22:33
@samdoran
Copy link
Contributor Author

samdoran commented Jan 3, 2024

Change detection isn't finding any changed files, so tests are not running and no coverage report is being generated. 😕

@samdoran samdoran force-pushed the COST-3394/COST-4534-support-multiple-filters-per-field branch 2 times, most recently from 1f53d6d to 378a471 Compare January 4, 2024 18:30
@samdoran samdoran marked this pull request as draft January 4, 2024 18:30
@samdoran samdoran force-pushed the COST-3394/COST-4534-support-multiple-filters-per-field branch 10 times, most recently from e4beebe to dda3102 Compare January 4, 2024 22:23
@samdoran samdoran marked this pull request as ready for review January 4, 2024 22:24
myersCody
myersCody previously approved these changes Jan 5, 2024
@samdoran samdoran force-pushed the COST-3394/COST-4534-support-multiple-filters-per-field branch from dda3102 to a326643 Compare January 5, 2024 22:20
@samdoran samdoran force-pushed the COST-3394/COST-4534-support-multiple-filters-per-field branch from a326643 to 1ef695f Compare January 8, 2024 16:08
@samdoran samdoran enabled auto-merge (squash) January 8, 2024 16:13
Copy link

sonarcloud bot commented Jan 8, 2024

@samdoran samdoran merged commit e4a8c29 into main Jan 8, 2024
10 checks passed
@samdoran samdoran deleted the COST-3394/COST-4534-support-multiple-filters-per-field branch January 8, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants