-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent running migration CI check if removal label is present #5075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgoodfred
added
skip-migration-check
Skip migration test in CI. Useful for separating model changes from the migration.
and removed
model-removal
labels
Apr 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5075 +/- ##
=======================================
- Coverage 94.1% 94.1% -0.0%
=======================================
Files 377 377
Lines 31346 31346
Branches 3715 3715
=======================================
- Hits 29507 29503 -4
- Misses 1173 1176 +3
- Partials 666 667 +1 |
samdoran
reviewed
Apr 30, 2024
Co-authored-by: Sam Doran <sdoran@redhat.com>
maskarb
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ok-to-skip-smokes
skip-migration-check
Skip migration test in CI. Useful for separating model changes from the migration.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4947
Description
This change will allow skipping the migration check if we are removing fields from a model since the fields should be removed prior to the migration to drop those fields running.
Adding this allows us to follow along with the flow for removing fields suggested in this gist: https://gist.github.com/majackson/493c3d6d4476914ca9da63f84247407b#removing-fields-or-tables
Testing
Release Notes