This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of proving specifications for various arrow combinators, I accumulated a whole bunch of general
Vector.t
proofs. This PR adds those toVectorUtils.v
. In order to make the proofs easier, I changed some of the custom vector functions (vreverse
,vsnoc
, andvunsnoc
) to recurse on the length of the vector, instead of on the vector itself.The one other change here is that I took
fold_left_S
out of thevsimpl
set of rewrite hints. The problem is that it triggers any time it seesfold_left
with a length that matchesS _
-- and4
is just a notation forS (S (S (S 0)))
, so if you have afold_left
with length 8 it'll apply itself 8 times and make your goal huge. It's still added to thepush_vector_fold
set of hints, so you can get the same behavior as before by writingautorewrite with push_vector_fold vsimpl
instead of justautorewrite with vsimpl
, but you have more control over whether that particular lemma gets used.