Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check the tests folders with eslint not just src, fix existing errors #68

Closed
wants to merge 6 commits into from
Closed

check the tests folders with eslint not just src, fix existing errors #68

wants to merge 6 commits into from

Conversation

DustinAlandzes
Copy link
Contributor

@DustinAlandzes DustinAlandzes commented May 9, 2021

This pull requests adds the test folder to be checked by eslint

commandByte and metadata are unused variables

and this line gave me the "strict-booleans/no-nullable-numbers" error
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/strict-boolean-expressions.md

const lastFrame = metadata.lastFrame || game.getLatestFrame().frame;

101:23 error Unexpected nullable number value in conditional. Please handle the nullish/zero/NaN cases explicitly strict-booleans/no-nullable-numbers

@DustinAlandzes DustinAlandzes changed the title add tests to eslint check, fix existing errors check the tests folders with eslint not just src, fix existing errors May 9, 2021
@vinceau
Copy link
Member

vinceau commented May 10, 2021

Superseded by 0e0c3a2

@vinceau vinceau closed this May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants