-
-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user redirected to login after signup #67
Conversation
view.dismissLoadingDialog(); | ||
} catch (JSONException e) { | ||
} catch (Exception e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, catching a more specific exception is a better practice than catching a general one. Any particular reason for the change in this method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the JSONException was erased due to the changed of methodology
so the java vm doesn't accept this specific exception
so instead of erasing the catch statment I changed it to a general catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense! Overlooked the commented code.
The checks are also failing. Look into that. |
the checks are failing due to a problem in the Travis CI |
Signed-off-by: momen-ghulmi <momen.ghulmi@gmail.com>
One of my other projects was also getting the same error. You can do the similar change here also. See this commit : Swati4star/Images-to-PDF@15150d8 |
thanks for the advice |
Hi! The changes look fine. |
fix for bug #62