Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user redirected to login after signup #67

Merged
merged 3 commits into from
Jun 12, 2018
Merged

user redirected to login after signup #67

merged 3 commits into from
Jun 12, 2018

Conversation

momen-ghulmi
Copy link
Contributor

fix for bug #62

view.dismissLoadingDialog();
} catch (JSONException e) {
} catch (Exception e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, catching a more specific exception is a better practice than catching a general one. Any particular reason for the change in this method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the JSONException was erased due to the changed of methodology
so the java vm doesn't accept this specific exception
so instead of erasing the catch statment I changed it to a general catch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense! Overlooked the commented code.

@Swati4star
Copy link
Member

The checks are also failing. Look into that.

@momen-ghulmi
Copy link
Contributor Author

the checks are failing due to a problem in the Travis CI
it's failing to acquire an asset from google and giving a connection time out exception

Signed-off-by: momen-ghulmi <momen.ghulmi@gmail.com>
@momen-ghulmi
Copy link
Contributor Author

there are problems in the travis build in the project
I tried again and was faced with another resource error
2018-06-09-21-29-travis-ci org

@Swati4star
Copy link
Member

One of my other projects was also getting the same error. You can do the similar change here also. See this commit : Swati4star/Images-to-PDF@15150d8

@momen-ghulmi
Copy link
Contributor Author

thanks for the advice
it worked

@Swati4star
Copy link
Member

Hi! The changes look fine.
You can now revert the Android/build.gradle file change (I have already merged that change from another PR), and squash the commits into a single one.

@Swati4star Swati4star merged commit 81948f3 into project-travel-mate:master Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants