fix(sync): search for certificates in sync certDir #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of expecting certain filenames Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
eusebiu-constantin-petu-dbk
requested review from
rchincha and
andaaron
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2558 +/- ##
==========================================
- Coverage 92.72% 92.66% -0.06%
==========================================
Files 169 169
Lines 22467 22502 +35
==========================================
+ Hits 20832 20851 +19
- Misses 1018 1031 +13
- Partials 617 620 +3 ☔ View full report in Codecov by Sentry. |
andaaron
approved these changes
Aug 1, 2024
|
cert filenames should be relative to the cert dir and the user can specify them in the config explicitly, else fallback to defaults (current behavior) And instead of looking at the extension, maybe we first assume PEM format, try and load and if that fails try DER format, if that fails, then return error. |
|
@eusebiu-constantin-petu-dbk let's close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of expecting certain filenames
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.