fix(logout): clear localStorage after logout #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clearing localStorage before making logout call makes axios to not send session cookies to backend so it can not handle the request and returns 500. Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
Codecov Report
@@ Coverage Diff @@
## main #390 +/- ##
==========================================
- Coverage 86.73% 86.09% -0.65%
==========================================
Files 53 53
Lines 1553 1553
Branches 416 406 -10
==========================================
- Hits 1347 1337 -10
- Misses 193 203 +10
Partials 13 13
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
raulkele
approved these changes
Nov 2, 2023
|
@andaaron @peusebiu Is this still needed? |
|
I do not know, I was travelling while this issue was opened, and did not discuss it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clearing localStorage before making logout call
makes axios to not send session cookies to
backend so it can not handle the request and returns 500.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.