Skip to content

Commit 064e534

Browse files
JasonChenCJNanlinXie
authored andcommitted
vuart: use pulse irq to assert COM1_IRQ
vuart irq COM1_IRQ is configured as active low in ACPI table, so using GSI_FALLING_PULSE. Tracked-On: #1269 Signed-off-by: Jason Chen CJ <jason.cj.chen@intel.com>
1 parent 099203c commit 064e534

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

hypervisor/debug/vuart.c

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -133,13 +133,9 @@ static void vuart_toggle_intr(struct acrn_vuart *vu)
133133
intr_reason = vuart_intr_reason(vu);
134134

135135
if (intr_reason != IIR_NOPEND) {
136-
vpic_set_irq(vu->vm, COM1_IRQ, GSI_SET_HIGH);
137-
138-
vioapic_set_irq(vu->vm, COM1_IRQ, GSI_SET_HIGH);
139-
140-
vpic_set_irq(vu->vm, COM1_IRQ, GSI_SET_LOW);
141-
142-
vioapic_set_irq(vu->vm, COM1_IRQ, GSI_SET_LOW);
136+
/* active low for COM1_IRQ polarity */
137+
vpic_set_irq(vu->vm, COM1_IRQ, GSI_FALLING_PULSE);
138+
vioapic_set_irq(vu->vm, COM1_IRQ, GSI_FALLING_PULSE);
143139
}
144140
}
145141

0 commit comments

Comments
 (0)