Skip to content

Commit 0ccd74b

Browse files
Shawnshhlijinxia
authored andcommitted
HV:modified vm_description and vm_hw_info memebers' type
transfer num_vcpus,exp_num_vcpus to uint16_t. transfer vm_hw_num_cores to uint16_t. Signed-off-by: Huihuang Shi <huihuang.shi@intel.com> Acked-by: Eddie Dong <eddie.dong@intel.com>
1 parent 39159eb commit 0ccd74b

File tree

8 files changed

+20
-19
lines changed

8 files changed

+20
-19
lines changed

hypervisor/arch/x86/ept.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,7 @@ int ept_mmap(struct vm *vm, uint64_t hpa,
469469
uint64_t gpa, uint64_t size, uint32_t type, uint32_t prot)
470470
{
471471
struct map_params map_params;
472-
int i;
472+
uint16_t i;
473473
struct vcpu *vcpu;
474474

475475
/* Setup memory map parameters */
@@ -516,7 +516,7 @@ int ept_update_mt(struct vm *vm, uint64_t hpa,
516516
{
517517
struct map_params map_params;
518518
struct vcpu *vcpu;
519-
int i;
519+
uint16_t i;
520520

521521
/* Setup memory map parameters */
522522
map_params.page_table_type = PTT_EPT;

hypervisor/arch/x86/guest/guest.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ is_vm0(struct vm *vm)
3636

3737
inline struct vcpu *vcpu_from_vid(struct vm *vm, uint16_t vcpu_id)
3838
{
39-
int i;
39+
uint16_t i;
4040
struct vcpu *vcpu;
4141

4242
foreach_vcpu(i, vm, vcpu) {
@@ -49,7 +49,7 @@ inline struct vcpu *vcpu_from_vid(struct vm *vm, uint16_t vcpu_id)
4949

5050
inline struct vcpu *vcpu_from_pid(struct vm *vm, uint16_t pcpu_id)
5151
{
52-
int i;
52+
uint16_t i;
5353
struct vcpu *vcpu;
5454

5555
foreach_vcpu(i, vm, vcpu) {
@@ -62,7 +62,7 @@ inline struct vcpu *vcpu_from_pid(struct vm *vm, uint16_t pcpu_id)
6262

6363
inline struct vcpu *get_primary_vcpu(struct vm *vm)
6464
{
65-
int i;
65+
uint16_t i;
6666
struct vcpu *vcpu;
6767

6868
foreach_vcpu(i, vm, vcpu) {
@@ -91,7 +91,7 @@ inline uint64_t vcpumask2pcpumask(struct vm *vm, uint64_t vdmask)
9191

9292
inline bool vm_lapic_disabled(struct vm *vm)
9393
{
94-
int i;
94+
uint16_t i;
9595
struct vcpu *vcpu;
9696

9797
foreach_vcpu(i, vm, vcpu) {

hypervisor/arch/x86/guest/vioapic.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ vioapic_write(struct vioapic *vioapic, uint32_t addr, uint32_t data)
373373
* to update their vlapic trigger-mode registers.
374374
*/
375375
if ((changed & ~(IOAPIC_RTE_INTMASK | IOAPIC_RTE_INTPOL)) != 0U) {
376-
int i;
376+
uint16_t i;
377377
struct vcpu *vcpu;
378378

379379
dev_dbg(ACRN_DBG_IOAPIC,

hypervisor/arch/x86/guest/vlapic.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ vm_lapic_from_pcpuid(struct vm *vm, uint16_t pcpu_id)
121121

122122
static uint16_t vm_apicid2vcpu_id(struct vm *vm, uint8_t lapicid)
123123
{
124-
int i;
124+
uint16_t i;
125125
struct vcpu *vcpu;
126126

127127
foreach_vcpu(i, vm, vcpu) {
@@ -138,7 +138,7 @@ static uint64_t
138138
vm_active_cpus(struct vm *vm)
139139
{
140140
uint64_t dmask = 0;
141-
int i;
141+
uint16_t i;
142142
struct vcpu *vcpu;
143143

144144
foreach_vcpu(i, vm, vcpu) {

hypervisor/arch/x86/guest/vm.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ int create_vm(struct vm_description *vm_desc, struct vm **rtn_vm)
8787
/* Init mmio list */
8888
INIT_LIST_HEAD(&vm->mmio_list);
8989

90-
if (vm->hw.num_vcpus == 0)
90+
if (vm->hw.num_vcpus == 0U)
9191
vm->hw.num_vcpus = phys_cpu_num;
9292

9393
vm->hw.vcpu_array =
@@ -185,7 +185,8 @@ int create_vm(struct vm_description *vm_desc, struct vm **rtn_vm)
185185

186186
int shutdown_vm(struct vm *vm)
187187
{
188-
int i, status = 0;
188+
int status = 0;
189+
uint16_t i;
189190
struct vcpu *vcpu = NULL;
190191

191192
if (vm == NULL)
@@ -262,7 +263,7 @@ int start_vm(struct vm *vm)
262263
*/
263264
void pause_vm(struct vm *vm)
264265
{
265-
int i;
266+
uint16_t i;
266267
struct vcpu *vcpu = NULL;
267268

268269
if (vm->state == VM_PAUSED)
@@ -276,7 +277,7 @@ void pause_vm(struct vm *vm)
276277

277278
void resume_vm(struct vm *vm)
278279
{
279-
int i;
280+
uint16_t i;
280281
struct vcpu *vcpu = NULL;
281282

282283
foreach_vcpu(i, vm, vcpu)
@@ -361,7 +362,7 @@ void vm_fixup(struct vm *vm)
361362
if (is_vm0(vm) && (vm->hw.exp_num_vcpus < vm->hw.num_vcpus)) {
362363
struct vm_description *vm_desc = &vm0_desc;
363364
struct vcpu *vcpu;
364-
int i;
365+
uint16_t i;
365366

366367
foreach_vcpu(i, vm, vcpu) {
367368
if (!vcpu_in_vm_desc(vcpu, vm_desc)) {

hypervisor/arch/x86/trusty.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ static void create_secure_world_ept(struct vm *vm, uint64_t gpa_orig,
8484
IA32E_EPT_X_BIT);
8585
void *sub_table_addr = NULL, *pml4_base = NULL;
8686
struct vm *vm0 = get_vm_from_vmid(0);
87-
int i;
87+
uint16_t i;
8888
struct vcpu *vcpu;
8989

9090
if (vm0 == NULL) {

hypervisor/debug/shell_internal.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,7 @@ int shell_list_vcpu(struct shell *p_shell,
503503
spinlock_obtain(&vm_list_lock);
504504
list_for_each(pos, &vm_list) {
505505
char state[32];
506-
int i;
506+
uint16_t i;
507507

508508
vm = list_entry(pos, struct vm, list);
509509
foreach_vcpu(i, vm, vcpu) {

hypervisor/include/arch/x86/guest/vm.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ struct vm_attr {
2121
};
2222

2323
struct vm_hw_info {
24-
int num_vcpus; /* Number of total virtual cores */
25-
int exp_num_vcpus; /* Number of real expected virtual cores */
24+
uint16_t num_vcpus; /* Number of total virtual cores */
25+
uint16_t exp_num_vcpus; /* Number of real expected virtual cores */
2626
int created_vcpus; /* Number of created vcpus */
2727
struct vcpu **vcpu_array; /* vcpu array of this VM */
2828
uint64_t gpa_lowtop; /* top lowmem gpa of this VM */
@@ -163,7 +163,7 @@ struct vm_description {
163163
*/
164164
int *vm_hw_logical_core_ids;
165165
unsigned char GUID[16]; /* GUID of the vm will be created */
166-
int vm_hw_num_cores; /* Number of virtual cores */
166+
uint16_t vm_hw_num_cores; /* Number of virtual cores */
167167
/* Whether secure world is enabled for current VM. */
168168
bool sworld_enabled;
169169
};

0 commit comments

Comments
 (0)