Skip to content

Commit 32d8510

Browse files
conghuic23acrnsi
authored andcommitted
hv: remove pr_dbg between stac/clac
As the pr_dbg will access sbuf which will call stac/clac inside, so can not put pr_dbg between stac/clac, it will case Page Fault. acrn_print_request is a debug feature, and it calls pr_dbg. when the loglevel is set to 6, there will be Page Fault. So, remove the caller for acrn_print_request and mask the function as unused, reserved for debug. Tracked-On: #3648 Signed-off-by: Conghui Chen <conghui.chen@intel.com> Reviewed-by: Yonghua Huang <yonghua.huang@intel.com>
1 parent 8d27c1e commit 32d8510

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

hypervisor/dm/io_req.c

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ static uint32_t acrn_vhm_notification_vector = VECTOR_HYPERVISOR_CALLBACK_VHM;
1818
#define MMIO_DEFAULT_VALUE_SIZE_8 (0xFFFFFFFFFFFFFFFFUL)
1919

2020
#if defined(HV_DEBUG)
21-
static void acrn_print_request(uint16_t vcpu_id, const struct vhm_request *req)
21+
__unused static void acrn_print_request(uint16_t vcpu_id, const struct vhm_request *req)
2222
{
2323
switch (req->type) {
2424
case REQ_MMIO:
@@ -122,12 +122,6 @@ int32_t acrn_insert_request(struct acrn_vcpu *vcpu, const struct io_request *io_
122122
*/
123123
set_vhm_req_state(vcpu->vm, vcpu->vcpu_id, REQ_STATE_PENDING);
124124

125-
#if defined(HV_DEBUG)
126-
stac();
127-
acrn_print_request(vcpu->vcpu_id, vhm_req);
128-
clac();
129-
#endif
130-
131125
/* signal VHM */
132126
arch_fire_vhm_interrupt();
133127

0 commit comments

Comments
 (0)