Skip to content

Commit 410c76a

Browse files
Geoffroy Van Cutsemwenlingz
authored andcommitted
hv: enhance ACRN shell interactive help
Enhance the ACRN shell interactive help. It is close to a 1-1 mapping with the online documentation but cut a little shorter in various places to make it more user-friendly when using it from the ACRN console. Tracked-On: #2829 Signed-off-by: Geoffroy Van Cutsem <geoffroy.vancutsem@intel.com>
1 parent a0de49d commit 410c76a

File tree

1 file changed

+20
-17
lines changed

1 file changed

+20
-17
lines changed

hypervisor/debug/shell_priv.h

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -36,62 +36,65 @@ struct shell {
3636
/* Shell Command list with parameters and help description */
3737
#define SHELL_CMD_HELP "help"
3838
#define SHELL_CMD_HELP_PARAM NULL
39-
#define SHELL_CMD_HELP_HELP "Display info about the supported shell commands."
39+
#define SHELL_CMD_HELP_HELP "Display information about supported hypervisor shell commands"
4040

4141
#define SHELL_CMD_VM_LIST "vm_list"
4242
#define SHELL_CMD_VM_LIST_PARAM NULL
43-
#define SHELL_CMD_VM_LIST_HELP "Lists all VMs (VM Name, VM ID, VM State)"
43+
#define SHELL_CMD_VM_LIST_HELP "List all VMs, displaying the VM name, ID, and state"
4444

4545
#define SHELL_CMD_VCPU_LIST "vcpu_list"
4646
#define SHELL_CMD_VCPU_LIST_PARAM NULL
47-
#define SHELL_CMD_VCPU_LIST_HELP "Lists all VCPU in all VMs"
47+
#define SHELL_CMD_VCPU_LIST_HELP "List all vCPUs in all VMs"
4848

4949
#define SHELL_CMD_VCPU_DUMPREG "vcpu_dumpreg"
5050
#define SHELL_CMD_VCPU_DUMPREG_PARAM "<vm id, vcpu id>"
51-
#define SHELL_CMD_VCPU_DUMPREG_HELP "Dump registers for a specific vcpu"
51+
#define SHELL_CMD_VCPU_DUMPREG_HELP "Dump registers for a specific vCPU"
5252

5353
#define SHELL_CMD_DUMPMEM "dumpmem"
5454
#define SHELL_CMD_DUMPMEM_PARAM "<addr, length>"
55-
#define SHELL_CMD_DUMPMEM_HELP "Dump physical memory"
55+
#define SHELL_CMD_DUMPMEM_HELP "Dump host memory, starting at a given address, and for a given length (in "\
56+
"bytes)"
5657

5758
#define SHELL_CMD_SOS_CONSOLE "sos_console"
5859
#define SHELL_CMD_SOS_CONSOLE_PARAM NULL
59-
#define SHELL_CMD_SOS_CONSOLE_HELP "Switch to SOS's console"
60+
#define SHELL_CMD_SOS_CONSOLE_HELP "Switch to the SOS's console. Use [Ctrl+Spacebar] to return to the ACRN shell "\
61+
"console"
6062

6163
#define SHELL_CMD_INTERRUPT "int"
6264
#define SHELL_CMD_INTERRUPT_PARAM NULL
63-
#define SHELL_CMD_INTERRUPT_HELP "show interrupt info per CPU"
65+
#define SHELL_CMD_INTERRUPT_HELP "List interrupt information per CPU"
6466

6567
#define SHELL_CMD_PTDEV "pt"
6668
#define SHELL_CMD_PTDEV_PARAM NULL
67-
#define SHELL_CMD_PTDEV_HELP "show pass-through device info"
69+
#define SHELL_CMD_PTDEV_HELP "Show pass-through device information"
6870

6971
#define SHELL_CMD_REBOOT "reboot"
7072
#define SHELL_CMD_REBOOT_PARAM NULL
71-
#define SHELL_CMD_REBOOT_HELP "trigger system reboot"
73+
#define SHELL_CMD_REBOOT_HELP "Trigger a system reboot (immediately)"
7274

7375
#define SHELL_CMD_IOAPIC "dump_ioapic"
7476
#define SHELL_CMD_IOAPIC_PARAM NULL
75-
#define SHELL_CMD_IOAPIC_HELP "show native ioapic info"
77+
#define SHELL_CMD_IOAPIC_HELP "Show native IOAPIC information"
7678

7779
#define SHELL_CMD_VIOAPIC "vioapic"
7880
#define SHELL_CMD_VIOAPIC_PARAM "<vm id>"
79-
#define SHELL_CMD_VIOAPIC_HELP "show vioapic info"
81+
#define SHELL_CMD_VIOAPIC_HELP "Show virtual IOAPIC (vIOAPIC) information for a specific VM"
8082

8183
#define SHELL_CMD_LOG_LVL "loglevel"
82-
#define SHELL_CMD_LOG_LVL_PARAM "[<console_loglevel> [<mem_loglevel> " \
83-
"[npk_loglevel]]]"
84-
#define SHELL_CMD_LOG_LVL_HELP "get(para is NULL), or set loglevel [0-6]"
84+
#define SHELL_CMD_LOG_LVL_PARAM "[<console_loglevel> [<mem_loglevel> [npk_loglevel]]]"
85+
#define SHELL_CMD_LOG_LVL_HELP "No argument: get the level of logging for the console, memory and npk. Set "\
86+
"the level by giving (up to) 3 parameters between 0 and 6 (verbose)"
8587

8688
#define SHELL_CMD_CPUID "cpuid"
8789
#define SHELL_CMD_CPUID_PARAM "<leaf> [subleaf]"
88-
#define SHELL_CMD_CPUID_HELP "cpuid leaf [subleaf], in hexadecimal"
90+
#define SHELL_CMD_CPUID_HELP "Display the CPUID leaf [subleaf], in hexadecimal"
8991

9092
#define SHELL_CMD_RDMSR "rdmsr"
9193
#define SHELL_CMD_RDMSR_PARAM "[-p<pcpu_id>] <msr_index>"
92-
#define SHELL_CMD_RDMSR_HELP "rdmsr -p<pcpu_id> <msr_index>, msr_index in hexadecimal"
94+
#define SHELL_CMD_RDMSR_HELP "Read the MSR at msr_index (in hexadecimal) for CPU ID pcpu_id"
9395

9496
#define SHELL_CMD_WRMSR "wrmsr"
9597
#define SHELL_CMD_WRMSR_PARAM "[-p<pcpu_id>] <msr_index> <value>"
96-
#define SHELL_CMD_WRMSR_HELP "wrmsr -p<pcpu_id> <msr_index> <value>, msr_index and value in hexadecimal"
98+
#define SHELL_CMD_WRMSR_HELP "Write value (in hexadecimal) to the MSR at msr_index (in hexadecimal) for CPU"\
99+
" ID pcpu_id"
97100
#endif /* SHELL_PRIV_H */

0 commit comments

Comments
 (0)