Skip to content

Commit 48fdeb2

Browse files
jsun26intelwenlingz
authored andcommitted
acrn-config: one button to generate config file
Currently we use separate button to generate board configuration files and scenario configuration files for hypervisor, this is not friendly from UX perspective. So remove redundant button on HV configuration generation. Tracked-On: #3854 Signed-off-by: Victor Sun <victor.sun@intel.com> Reviewed-by: Shuang Zheng <shuang.zheng@intel.com>
1 parent ab87940 commit 48fdeb2

File tree

3 files changed

+10
-46
lines changed

3 files changed

+10
-46
lines changed

misc/acrn-config/config_app/static/main.js

Lines changed: 5 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ $().ready(function(){
167167

168168
$('#save_scenario').on('click', function() {
169169
var name = $(this).data('id');
170-
if(name=="generate_board_src" || name=="generate_scenario_src") {
170+
if(name=="generate_config_src") {
171171
save_scenario(name);
172172
}
173173
else {
@@ -271,12 +271,7 @@ $().ready(function(){
271271
});
272272
});
273273

274-
$('#generate_board_src').on('click', function() {
275-
var dataId = $(this).data('id');
276-
$("#save_scenario").data('id', dataId);
277-
});
278-
279-
$('#generate_scenario_src').on('click', function() {
274+
$('#generate_config_src').on('click', function() {
280275
var dataId = $(this).data('id');
281276
$("#save_scenario").data('id', dataId);
282277
});
@@ -437,19 +432,12 @@ function save_scenario(generator=null){
437432
validate_message = 'Scenario setting existed, saved successfully with a new name: '
438433
+file_name+'\ninto acrn-hypervisor/misc/acrn-config/xmls/config-xmls/'+board_info+'/user_defined/.';
439434
}
440-
if(generator=="generate_board_src" || generator=="generate_scenario_src") {
441-
commit_confirm_message = validate_message+'\n\nGenerate source codes from scenario setting.'
442-
+'\n\nDo you want to commit changes to local tree?'
443-
commit_confirm = 'no'
444-
if(confirm(commit_confirm_message)) {
445-
commit_confirm = 'yes'
446-
}
435+
if(generator=="generate_config_src") {
447436
generator_config = {
448437
type: generator,
449438
board_info: $("select#board_info").val(),
450439
board_setting: "board_setting",
451440
scenario_setting: file_name,
452-
commit: commit_confirm
453441
}
454442
$.ajax({
455443
type : "POST",
@@ -461,10 +449,7 @@ function save_scenario(generator=null){
461449
status = result.status
462450
error_list = result.error_list
463451
if (status == 'success' && (JSON.stringify(error_list)=='{}' || JSON.stringify(error_list)=='null')) {
464-
if(commit_confirm == 'yes')
465-
alert(generator+' with commit successfully.');
466-
else
467-
alert(generator+' successfully.');
452+
alert(generator+' successfully.');
468453
} else {
469454
alert(generator+' failed. \nError list:\n'+JSON.stringify(error_list));
470455
}
@@ -573,19 +558,12 @@ function save_launch(generator=null) {
573558
+file_name+'\nto acrn-hypervisor/misc/acrn-config/xmls/config-xmls/'+board_info+'/user_defined/.';
574559
}
575560
if(generator != null) {
576-
commit_confirm_message = validate_message+'\n\nGenerate launch scripts from launch setting.'
577-
+'\n\nDo you want to commit changes to local tree?'
578-
commit_confirm = 'no'
579-
if(confirm(commit_confirm_message)) {
580-
commit_confirm = 'yes'
581-
}
582561
generator_config = {
583562
type: generator,
584563
board_info: $("select#board_info").val(),
585564
board_setting: "board_setting",
586565
scenario_setting: $("select#scenario_name").val(),
587566
launch_setting: file_name,
588-
commit: commit_confirm
589567
}
590568
$.ajax({
591569
type : "POST",
@@ -597,11 +575,7 @@ function save_launch(generator=null) {
597575
status = result.status
598576
error_list = result.error_list
599577
if (status == 'success' && (JSON.stringify(error_list)=='{}' || JSON.stringify(error_list)=='null')) {
600-
if(commit_confirm == 'yes')
601-
alert(generator+' successfully into '+
602-
'acrn-hypervisor/misc/acrn-config/xmls/config-xmls/'+board_info+'/output/ with changes committed.');
603-
else
604-
alert(generator+' successfully into '+
578+
alert(generator+' successfully into '+
605579
'acrn-hypervisor/misc/acrn-config/xmls/config-xmls/'+board_info+'/output/.');
606580
} else {
607581
alert(generator+' failed. \nError list:\n'+JSON.stringify(error_list));

misc/acrn-config/config_app/templates/scenario.html

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,8 @@ <h4 class="modal-title" id="myModalLabel">Save as</h4>
5757
</button>
5858
</div>
5959
<div class="col-sm-2">
60-
<button type="button" id="generate_board_src" data-id="generate_board_src" class="btn btn-primary"
61-
data-toggle="modal" data-target="#save_modal">Generate Board SRC
62-
</button>
63-
</div>
64-
<div class="col-sm-2">
65-
<button type="button" id="generate_scenario_src" data-id="generate_scenario_src" class="btn btn-primary"
66-
data-toggle="modal" data-target="#save_modal">Generate Scenario SRC
60+
<button type="button" id="generate_config_src" data-id="generate_config_src" class="btn btn-primary"
61+
data-toggle="modal" data-target="#save_modal">Generate configuration files
6762
</button>
6863
</div>
6964
{% else %}
@@ -74,12 +69,7 @@ <h4 class="modal-title" id="myModalLabel">Save as</h4>
7469
</div>
7570
<div class="col-sm-2">
7671
<button type="button" disabled class="btn btn-primary" data-toggle="modal" data-target="#save_modal">
77-
Generate Board SRC
78-
</button>
79-
</div>
80-
<div class="col-sm-2">
81-
<button type="button" disabled class="btn btn-primary" data-toggle="modal" data-target="#save_modal">
82-
Generate Scenario SRC
72+
Generate configuration files
8373
</button>
8474
</div>
8575
{% endif %}

misc/acrn-config/config_app/views.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -384,14 +384,14 @@ def generate_src():
384384
msg = {}
385385
error_list = {}
386386
status = 'success'
387-
if src_type == 'generate_board_src':
387+
if src_type == 'generate_config_src':
388388
try:
389389
from board_config.board_cfg_gen import ui_entry_api
390390
error_list = ui_entry_api(board_info_xml, scenario_setting_xml, commit)
391391
except Exception as error:
392392
status = 'fail'
393393
error_list = {'board setting error': str(error)}
394-
elif src_type == 'generate_scenario_src':
394+
395395
try:
396396
from scenario_config.scenario_cfg_gen import ui_entry_api
397397
error_list = ui_entry_api(board_info_xml, scenario_setting_xml, commit)

0 commit comments

Comments
 (0)