Skip to content

Commit 8707834

Browse files
donshengacrnsi
authored andcommitted
HV: remove the function get_bar_base()
There is no need to call get_bar_base(), as new_bar is set to val & mask, where mask is the bar size mask, so new_base has already been set to be the bar base address before get_bar_base() is called on it. Tracked-On: #3241 Signed-off-by: dongshen <dongsheng.x.zhang@intel.com> Reviewed-by: Eddie Dong <eddie.dong@intel.com>
1 parent 74b7889 commit 8707834

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

hypervisor/dm/vpci/pci_pt.c

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,6 @@
3333
#include <logmsg.h>
3434
#include "vpci_priv.h"
3535

36-
static inline uint32_t get_bar_base(uint32_t bar)
37-
{
38-
return bar & PCIM_BAR_MEM_BASE;
39-
}
40-
4136
/**
4237
* @pre vdev != NULL
4338
* @pre vdev->vpci != NULL
@@ -215,13 +210,12 @@ static void vdev_pt_write_vbar(struct pci_vdev *vdev, uint32_t offset, uint32_t
215210
new_bar = val & mask;
216211
if (bar_update_normal) {
217212
if (is_msix_table_bar) {
218-
vdev->bar[idx].base = get_bar_base(new_bar);
213+
vdev->bar[idx].base = new_bar;
219214
vdev_pt_remap_msix_table_bar(vdev);
220215
} else {
221-
vdev_pt_remap_generic_mem_vbar(vdev, idx,
222-
get_bar_base(new_bar));
216+
vdev_pt_remap_generic_mem_vbar(vdev, idx, new_bar);
223217

224-
vdev->bar[idx].base = get_bar_base(new_bar);
218+
vdev->bar[idx].base = new_bar;
225219
}
226220
}
227221
break;

0 commit comments

Comments
 (0)