Skip to content

Commit 8bde372

Browse files
junjiemao1lijinxia
authored andcommitted
kconfig: enforce remaking config.mk after oldconfig changes .config
Without any command under the .config target, config.mk will not be remade in the same execution of make after oldconfig changes .config. This can result to inconsistency between .config and the built image right after .config is changed. Tracked-On: #1588 Signed-off-by: Junjie Mao <junjie.mao@intel.com> Reviewed-by: Anthony Xu <anthony.xu@intel.com>
1 parent c7907a8 commit 8bde372

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

hypervisor/scripts/kconfig/kconfig.mk

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,11 @@ $(eval $(call check_dep_py3lib,kconfiglib,KCONFIG_DEPS))
3838

3939
# This target invoke silentoldconfig to generate or update a .config. Useful as
4040
# a prerequisite of other targets depending on .config.
41+
#
42+
# A dummy command is necessary to trigger the remaking of config.mk right after
43+
# oldconfig changes HV_CONFIG in the same execution of make.
4144
$(HV_OBJDIR)/$(HV_CONFIG): oldconfig
45+
@true
4246

4347
# Note: This target must not depend on a phony target (e.g. oldconfig) because
4448
# it'll trigger endless re-execution of make.

0 commit comments

Comments
 (0)