hv: vpci: refine comment for pci_vdev_update_vbar_base

lifeix · wenlingz · commit bbdf0199d9ee · 2020-04-13T11:39:58.000+08:00
Refine why we set the base_gpa to zero for a vBAR. Tracked-On: #3475 Signed-off-by: Li Fei1 <fei1.li@intel.com>
diff --git a/hypervisor/dm/vpci/vdev.c b/hypervisor/dm/vpci/vdev.c
@@ -138,10 +138,9 @@ static void pci_vdev_update_vbar_base(struct pci_vdev *vdev, uint32_t idx)
 	}
 
 	if ((base != 0UL) && !ept_is_mr_valid(vm, base, vdev->vbars[idx].size)) {
-		pr_fatal("%s, %x:%x.%x set invalid bar[%d] base: 0x%lx, size: 0x%lx\n", __func__,
+		pr_warn("%s, %x:%x.%x set invalid bar[%d] base: 0x%lx, size: 0x%lx\n", __func__,
 			vdev->bdf.bits.b, vdev->bdf.bits.d, vdev->bdf.bits.f, idx, base, vdev->vbars[idx].size);
-		/* If guest set a invalid GPA, ignore it temporarily */
-		base = 0UL;
+		base = 0UL;	/* 0UL means invalid GPA, so that EPT won't map */
 	}
 
 	vdev->vbars[idx].base_gpa = base;

Original file line number	Diff line number	Diff line change
`@@ -138,10 +138,9 @@ static void pci_vdev_update_vbar_base(struct pci_vdev *vdev, uint32_t idx)`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`if ((base != 0UL) && !ept_is_mr_valid(vm, base, vdev->vbars[idx].size)) {`
`141`		`- pr_fatal("%s, %x:%x.%x set invalid bar[%d] base: 0x%lx, size: 0x%lx\n", __func__,`
	`141`	`+ pr_warn("%s, %x:%x.%x set invalid bar[%d] base: 0x%lx, size: 0x%lx\n", __func__,`
`142`	`142`	`vdev->bdf.bits.b, vdev->bdf.bits.d, vdev->bdf.bits.f, idx, base, vdev->vbars[idx].size);`
`143`		`- /* If guest set a invalid GPA, ignore it temporarily */`
`144`		`- base = 0UL;`
	`143`	`+ base = 0UL; /* 0UL means invalid GPA, so that EPT won't map */`
`145`	`144`	`}`
`146`	`145`
`147`	`146`	`vdev->vbars[idx].base_gpa = base;`