Skip to content

Commit bd97e5c

Browse files
yang8621NanlinXie
authored andcommitted
dm: rpmb: Support RPMB mode config from launch.sh
physical RPMB is accessed if "phisycal_rpmb" is specified in launch.sh. Also it reserves some RPMB area with a fixed size(32KB) for AttKB and future usage, which is RO for UOS. Tracked-On: #1544 Signed-off-by: Huang, Yang <yang.huang@intel.com> Acked-by: Zhu Bing <bing.zhu@intel.com>
1 parent 107eaa3 commit bd97e5c

File tree

2 files changed

+13
-18
lines changed

2 files changed

+13
-18
lines changed

devicemodel/hw/pci/virtio/virtio_rpmb.c

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@
5757
#define VIRTIO_RPMB_MAXSEGS 5
5858
#define ADDR_NOT_PRESENT -2
5959

60+
static const char PHYSICAL_RPMB_STR[] = "physical_rpmb";
6061
static int virtio_rpmb_debug = 1;
6162
#define DPRINTF(params) do { if (virtio_rpmb_debug) printf params; } while (0)
6263
#define WPRINTF(params) (printf params)
@@ -538,20 +539,14 @@ virtio_rpmb_init(struct vmctx *ctx, struct pci_vdev *dev, char *opts)
538539
goto out;
539540
}
540541

541-
// TODO: keep it for self-adaption rpmb mode
542-
/*rc = rpmb_get_counter(RPMB_PHY_MODE, key, &rpmb_counter, &rpmb_result);
543-
if (rc) {
544-
DPRINTF(("rpmb_get_counter failed\n"));
545-
goto out;
546-
}*/
547-
548542
memset(key, 0, RPMB_KEY_32_LEN);
549-
/*TODO: hardcode rpmb mode to RPMB_SIM_MODE*/
550-
rpmb_result = RPMB_RES_GENERAL_FAILURE;
551-
if (rpmb_result == RPMB_RES_OK) {
543+
544+
if (opts && !strncmp(opts, PHYSICAL_RPMB_STR, sizeof(PHYSICAL_RPMB_STR))) {
545+
DPRINTF(("RPMB in physical mode!\n"));
552546
rpmb_mode_init(RPMB_PHY_MODE);
553547
rpmb_block_count = rpmb_search_size(RPMB_PHY_MODE, key, 0);
554548
} else {
549+
DPRINTF(("RPMB in simulated mode!\n"));
555550
rc = rpmb_sim_key_init(key);
556551
if (rc) {
557552
DPRINTF(("rpmb_sim_key_init failed!\n"));
@@ -565,7 +560,6 @@ virtio_rpmb_init(struct vmctx *ctx, struct pci_vdev *dev, char *opts)
565560
}
566561

567562
rpmb_mode_init(RPMB_SIM_MODE);
568-
569563
rpmb_block_count = rpmb_search_size(RPMB_SIM_MODE, key, 0);
570564
}
571565

devicemodel/hw/platform/rpmb/rpmb_backend.c

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,15 +64,16 @@ static uint16_t get_rpmb_blocks(void)
6464
return rpmb_get_blocks();
6565
}
6666

67-
//TODO: hardcode keybox size. It will be read from keybox header from RPMB.
67+
/* Common area of RPMB refers to the start area of RPMB
68+
* shared among all UOS with RO access.
69+
* It's predefined to 32KB in size which contains:
70+
* AttKB(up to 16KB), RPMB info header (256B)
71+
* and the remaining size for future uasge.
72+
*/
6873
static uint16_t get_common_blocks(void)
6974
{
70-
uint16_t kb_blocks;
71-
uint32_t kb_size = 15872;
72-
73-
kb_blocks = (kb_size + (RPMB_BLOCK_SIZE -1)) / RPMB_BLOCK_SIZE;
74-
//reserve for simulated rpmb + KBox header + padding
75-
return kb_blocks + 1 + 1 + 1;
75+
uint16_t common_size = 32 * 1024;
76+
return common_size / RPMB_BLOCK_SIZE;
7677
}
7778

7879
static uint16_t get_accessible_blocks(void)

0 commit comments

Comments
 (0)