Skip to content

Commit d14a7db

Browse files
JasonChenCJjren1
authored andcommitted
retpoline: add indirect thunk support
for gcc version > 7.3, enable CONFIG_RETPOLINE Signed-off-by: Jason Chen CJ <jason.cj.chen@intel.com>
1 parent c244e8b commit d14a7db

File tree

5 files changed

+75
-2
lines changed

5 files changed

+75
-2
lines changed

hypervisor/Makefile

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,19 @@ ifeq ($(PLATFORM),uefi)
153153
C_SRCS += bsp/$(PLATFORM)/cmdline.c
154154
endif
155155

156+
# retpoline support
157+
ifeq (true, $(shell [ $(GCC_MAJOR) -eq 7 ] && [ $(GCC_MINOR) -ge 3 ] && echo true))
158+
CFLAGS += -mindirect-branch=thunk-extern -mindirect-branch-register
159+
CFLAGS += -DCONFIG_RETPOLINE
160+
S_SRCS += arch/x86/retpoline-thunk.S
161+
else
162+
ifeq (true, $(shell [ $(GCC_MAJOR) -ge 8 ] && echo true))
163+
CFLAGS += -mindirect-branch=thunk-extern -mindirect-branch-register
164+
CFLAGS += -DCONFIG_RETPOLINE
165+
S_SRCS += arch/x86/retpoline-thunk.S
166+
endif
167+
endif
168+
156169
C_OBJS := $(patsubst %.c,$(HV_OBJDIR)/%.o,$(C_SRCS))
157170
ifeq ($(RELEASE),0)
158171
C_OBJS += $(patsubst %.c,$(HV_OBJDIR)/%.o,$(D_SRCS))

hypervisor/arch/x86/retpoline-thunk.S

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,61 @@
1+
/*
2+
* Copyright (C) 2018 Intel Corporation. All rights reserved.
3+
*
4+
* Redistribution and use in source and binary forms, with or without
5+
* modification, are permitted provided that the following conditions
6+
* are met:
7+
*
8+
* * Redistributions of source code must retain the above copyright
9+
* notice, this list of conditions and the following disclaimer.
10+
* * Redistributions in binary form must reproduce the above copyright
11+
* notice, this list of conditions and the following disclaimer in
12+
* the documentation and/or other materials provided with the
13+
* distribution.
14+
* * Neither the name of Intel Corporation nor the names of its
15+
* contributors may be used to endorse or promote products derived
16+
* from this software without specific prior written permission.
17+
*
18+
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
19+
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
20+
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
21+
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
22+
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23+
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24+
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25+
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26+
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27+
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28+
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29+
*/
30+
31+
.macro retpoline_thunk reg:req
32+
33+
.align 8
34+
.global __x86_indirect_thunk_\reg
35+
__x86_indirect_thunk_\reg:
36+
call 22f
37+
11:
38+
pause
39+
jmp 11b
40+
22:
41+
mov %\reg, (%rsp)
42+
ret
43+
.endm
44+
45+
.section .retpoline_thunk, "ax"
46+
47+
retpoline_thunk rax
48+
retpoline_thunk rbx
49+
retpoline_thunk rcx
50+
retpoline_thunk rdx
51+
retpoline_thunk rdi
52+
retpoline_thunk rsi
53+
retpoline_thunk rbp
54+
retpoline_thunk r8
55+
retpoline_thunk r9
56+
retpoline_thunk r10
57+
retpoline_thunk r11
58+
retpoline_thunk r12
59+
retpoline_thunk r13
60+
retpoline_thunk r14
61+
retpoline_thunk r15

hypervisor/bsp/ld/link_ram.ld.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ SECTIONS
3030
*(.text .text*) ;
3131
*(.gnu.linkonce.t*)
3232
*(.note.gnu.build-id)
33+
*(.retpoline_thunk)
3334
} > ram
3435

3536
.rodata :

hypervisor/bsp/sbl/include/bsp/bsp_cfg.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,5 +45,4 @@
4545
#define CONFIG_LOW_RAM_SIZE 0x000CF000
4646
#define CONFIG_RAM_START 0x6E000000
4747
#define CONFIG_RAM_SIZE 0x02000000 /* 32M */
48-
#define CONFIG_RETPOLINE
4948
#endif /* BSP_CFG_H */

hypervisor/bsp/uefi/include/bsp/bsp_cfg.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,5 +48,4 @@
4848
#define CONFIG_DMAR_PARSE_ENABLED 1
4949
#define CONFIG_GPU_SBDF 0x00000010 /* 0000:00:02.0 */
5050
#define CONFIG_EFI_STUB 1
51-
#define CONFIG_RETPOLINE
5251
#endif /* BSP_CFG_H */

0 commit comments

Comments
 (0)