Skip to content

Commit da0f28c

Browse files
yuchuyanglijinxia
authored andcommitted
HV: Bracket for the same level of precendence
The plus and minor have the same level of precedence. The Misra-C considers it as a violation. Added brackets in between addition and substraction oprators. Signed-off-by: Yang, Yu-chu <yu-chu.yang@intel.com> Acked-by: Anthony Xu <anthony.xu@intel.com>
1 parent 91337da commit da0f28c

File tree

7 files changed

+13
-12
lines changed

7 files changed

+13
-12
lines changed

hypervisor/arch/x86/guest/guest.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -649,7 +649,7 @@ uint64_t e820_alloc_low_memory(uint32_t size)
649649
struct e820_entry *entry, *new_entry;
650650

651651
/* We want memory in page boundary and integral multiple of pages */
652-
size = ((size + CPU_PAGE_SIZE - 1U) >> CPU_PAGE_SHIFT)
652+
size = (((size + CPU_PAGE_SIZE) - 1U) >> CPU_PAGE_SHIFT)
653653
<< CPU_PAGE_SHIFT;
654654

655655
for (i = 0U; i < e820_entries; i++) {
@@ -682,8 +682,8 @@ uint64_t e820_alloc_low_memory(uint32_t size)
682682
new_entry = &e820[e820_entries];
683683
new_entry->type = E820_TYPE_RESERVED;
684684
new_entry->baseaddr = end - size;
685-
new_entry->length = entry->baseaddr +
686-
entry->length - new_entry->baseaddr;
685+
new_entry->length = (entry->baseaddr +
686+
entry->length) - new_entry->baseaddr;
687687

688688
/* Shrink the existing entry and total available memory */
689689
entry->length -= new_entry->length;

hypervisor/arch/x86/guest/ucode.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ void acrn_update_ucode(struct vcpu *vcpu, uint64_t v)
4848

4949
data_size = UCODE_GET_DATA_SIZE(uhdr) + sizeof(struct ucode_header);
5050
data_page_num =
51-
(data_size + CPU_PAGE_SIZE - 1U) >> CPU_PAGE_SHIFT;
51+
((data_size + CPU_PAGE_SIZE) - 1U) >> CPU_PAGE_SHIFT;
5252

5353
ucode_ptr = alloc_pages(data_page_num);
5454
if (ucode_ptr == NULL) {

hypervisor/arch/x86/trusty.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,7 @@ bool initialize_trusty(struct vcpu *vcpu, uint64_t param)
481481

482482
/* init secure world environment */
483483
if (init_secure_world_env(vcpu,
484-
trusty_entry_gpa - trusty_base_gpa + TRUSTY_EPT_REBASE_GPA,
484+
(trusty_entry_gpa - trusty_base_gpa) + TRUSTY_EPT_REBASE_GPA,
485485
trusty_base_hpa, trusty_mem_size)) {
486486

487487
/* switch to Secure World */

hypervisor/include/arch/x86/mmu.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,8 @@
210210
#define MMU_MEM_ATTR_TYPE_MASK \
211211
(IA32E_PDPTE_PAT_BIT | IA32E_COMM_PCD_BIT | IA32E_COMM_PWT_BIT)
212212

213-
#define ROUND_PAGE_UP(addr) (((addr) + (uint64_t)CPU_PAGE_SIZE - 1UL) & CPU_PAGE_MASK)
213+
#define ROUND_PAGE_UP(addr) \
214+
((((addr) + (uint64_t)CPU_PAGE_SIZE) - 1UL) & CPU_PAGE_MASK)
214215
#define ROUND_PAGE_DOWN(addr) ((addr) & CPU_PAGE_MASK)
215216

216217
enum _page_table_type {

hypervisor/include/lib/util.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
#define offsetof(st, m) __builtin_offsetof(st, m)
1919

2020
/** Roundup (x/y) to ( x/y + (x%y) ? 1 : 0) **/
21-
#define INT_DIV_ROUNDUP(x, y) (((x)+(y)-1)/(y))
21+
#define INT_DIV_ROUNDUP(x, y) ((((x)+(y))-1)/(y))
2222

2323
#define min(x, y) ((x) < (y)) ? (x) : (y)
2424

hypervisor/lib/memory.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ void *malloc(unsigned int num_bytes)
245245
memory = allocate_mem(&Memory_Pool, num_bytes);
246246
} else {
247247
uint32_t page_num =
248-
(num_bytes + CPU_PAGE_SIZE - 1U) >> CPU_PAGE_SHIFT;
248+
((num_bytes + CPU_PAGE_SIZE) - 1U) >> CPU_PAGE_SHIFT;
249249
/* Request memory allocation through alloc_page */
250250
memory = alloc_pages(page_num);
251251
}
@@ -361,8 +361,8 @@ void *memcpy_s(void *d, size_t dmax, const void *s, size_t slen)
361361
ASSERT(false);
362362
}
363363

364-
if (((d > s) && (d <= (s + slen - 1U)))
365-
|| ((d < s) && (s <= (d + dmax - 1U)))) {
364+
if (((d > s) && (d <= ((s + slen) - 1U)))
365+
|| ((d < s) && (s <= ((d + dmax) - 1U)))) {
366366
ASSERT(false);
367367
}
368368

hypervisor/lib/sprintf.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ static int print_pow2(struct print_param *param,
335335

336336
/* assign parameter and apply width and precision */
337337
param->vars.value = pos;
338-
param->vars.valuelen = digitbuff + sizeof(digitbuff) - pos;
338+
param->vars.valuelen = (digitbuff + sizeof(digitbuff)) - pos;
339339

340340
ret = format_number(param);
341341

@@ -408,7 +408,7 @@ static int print_decimal(struct print_param *param, int64_t value)
408408

409409
/* assign parameter and apply width and precision */
410410
param->vars.value = pos;
411-
param->vars.valuelen = digitbuff + sizeof(digitbuff) - pos;
411+
param->vars.valuelen = (digitbuff + sizeof(digitbuff)) - pos;
412412

413413
ret = format_number(param);
414414

0 commit comments

Comments
 (0)