Skip to content

Commit e078ce7

Browse files
jsun26inteljren1
authored andcommitted
DM: hotfix for loop initial declaration in acpi_pm
for (int i = 0; i < ...; i++) is only allowed in C99 mode, so fix this coding style to: int i; for (i = 0; i < ...; i++) Signed-off-by: Victor Sun <victor.sun@intel.com> Acked-by: Eddie Dong <eddie.dong@intel.com>
1 parent 24ea869 commit e078ce7

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

devicemodel/hw/acpi/acpi_pm.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ static void dsdt_write_pct(void)
127127
static void dsdt_write_pss(struct vmctx *ctx, int vcpu_id)
128128
{
129129
uint8_t vcpu_px_cnt;
130+
int i;
130131
struct cpu_px_data *vcpu_px_data;
131132

132133
vcpu_px_cnt = get_vcpu_px_cnt(ctx, vcpu_id);
@@ -140,7 +141,7 @@ static void dsdt_write_pss(struct vmctx *ctx, int vcpu_id)
140141
}
141142

142143
/* copy and validate px data first */
143-
for (int i = 0; i < vcpu_px_cnt; i++) {
144+
for (i = 0; i < vcpu_px_cnt; i++) {
144145
if (get_vcpu_px_data(ctx, vcpu_id, i, vcpu_px_data + i)) {
145146
/* something must be wrong, so skip the write. */
146147
free(vcpu_px_data);
@@ -154,7 +155,7 @@ static void dsdt_write_pss(struct vmctx *ctx, int vcpu_id)
154155
dsdt_line(" Return (Package (0x%02X)", vcpu_px_cnt);
155156
dsdt_line(" {");
156157

157-
for (int i = 0; i < vcpu_px_cnt; i++) {
158+
for (i = 0; i < vcpu_px_cnt; i++) {
158159

159160
dsdt_line(" Package (0x%02X)", 6);
160161
dsdt_line(" {");
@@ -186,19 +187,21 @@ static void dsdt_write_pss(struct vmctx *ctx, int vcpu_id)
186187

187188
void pm_write_dsdt(struct vmctx *ctx, int ncpu)
188189
{
190+
int i;
191+
189192
/* Scope (_PR) */
190193
dsdt_line("");
191194
dsdt_line(" Scope (_PR)");
192195
dsdt_line(" {");
193-
for (int i = 0; i < ncpu; i++) {
196+
for (i = 0; i < ncpu; i++) {
194197
dsdt_line(" Processor (CPU%d, 0x%02X, 0x00000000, 0x00) {}",
195198
i, i);
196199
}
197200
dsdt_line(" }");
198201
dsdt_line("");
199202

200203
/* Scope (_PR.CPU(N)) */
201-
for (int i = 0; i < ncpu; i++) {
204+
for (i = 0; i < ncpu; i++) {
202205
dsdt_line(" Scope (_PR.CPU%d)", i);
203206
dsdt_line(" {");
204207
dsdt_line("");

0 commit comments

Comments
 (0)