Skip to content

Commit e12f88b

Browse files
chejianjNanlinXie
authored andcommitted
dm: virtio-console: remove unused virtio_console_cfgwrite
Virtio-console device specific configuration is readonly, callback for the cfgwrite is not required. This patch removed the unused virtio_console_cfgwrite. Tracked-On: #1364 Signed-off-by: Jian Jun Chen <jian.jun.chen@intel.com> Acked-by: Yu Wang <yu1.wang@intel.com>
1 parent 7961a5b commit e12f88b

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

devicemodel/hw/pci/virtio/virtio_console.c

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,6 @@ static void virtio_console_reset(void *);
148148
static void virtio_console_notify_rx(void *, struct virtio_vq_info *);
149149
static void virtio_console_notify_tx(void *, struct virtio_vq_info *);
150150
static int virtio_console_cfgread(void *, int, int, uint32_t *);
151-
static int virtio_console_cfgwrite(void *, int, int, uint32_t);
152151
static void virtio_console_neg_features(void *, uint64_t);
153152
static void virtio_console_control_send(struct virtio_console *,
154153
struct virtio_console_control *, const void *, size_t);
@@ -162,7 +161,7 @@ static struct virtio_ops virtio_console_ops = {
162161
virtio_console_reset, /* reset */
163162
NULL, /* device-wide qnotify */
164163
virtio_console_cfgread, /* read virtio config */
165-
virtio_console_cfgwrite, /* write virtio config */
164+
NULL, /* write virtio config */
166165
virtio_console_neg_features, /* apply negotiated features */
167166
NULL, /* called on guest set status */
168167
};
@@ -207,12 +206,6 @@ virtio_console_cfgread(void *vdev, int offset, int size, uint32_t *retval)
207206
return 0;
208207
}
209208

210-
static int
211-
virtio_console_cfgwrite(void *vdev, int offset, int size, uint32_t val)
212-
{
213-
return 0;
214-
}
215-
216209
static inline struct virtio_console_port *
217210
virtio_console_vq_to_port(struct virtio_console *console,
218211
struct virtio_vq_info *vq)

0 commit comments

Comments
 (0)