Skip to content

Commit e49233b

Browse files
JasonChenCJNanlinXie
authored andcommitted
ioapic: set default polarity setting as high active
high active should be default polarity setting for ioapic RTE Tracked-On: #1269 Signed-off-by: Jason Chen CJ <jason.cj.chen@intel.com>
1 parent 3b88d3c commit e49233b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

hypervisor/arch/x86/ioapic.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,8 @@ create_rte_for_legacy_irq(uint32_t irq, uint32_t vr)
175175
rte.full |= DEFAULT_DELIVERY_MODE;
176176
rte.full |= (IOAPIC_RTE_INTVEC & (uint64_t)vr);
177177

178-
/* FIXME: Fixed to active Low? */
179-
rte.full |= IOAPIC_RTE_INTALO;
178+
/* Fixed to active high */
179+
rte.full |= IOAPIC_RTE_INTAHI;
180180

181181
/* Dest field: legacy irq fixed to CPU0 */
182182
rte.full |= (1UL << IOAPIC_RTE_DEST_SHIFT);
@@ -200,8 +200,8 @@ create_rte_for_gsi_irq(uint32_t irq, uint32_t vr)
200200
rte.full |= DEFAULT_DELIVERY_MODE;
201201
rte.full |= (IOAPIC_RTE_INTVEC & (uint64_t)vr);
202202

203-
/* FIXME: Fixed to active Low? */
204-
rte.full |= IOAPIC_RTE_INTALO;
203+
/* Fixed to active high */
204+
rte.full |= IOAPIC_RTE_INTAHI;
205205

206206
/* Dest field */
207207
rte.full |= ((uint64_t)ALL_CPUS_MASK << IOAPIC_RTE_DEST_SHIFT);

0 commit comments

Comments
 (0)