Skip to content

Commit fcbf9d7

Browse files
fyin1acrnsi
authored andcommitted
makefile: fix efi stub install issue
In commit "d0489ef3b7efcd4feca0a5ee11b1fd4f9a88864a", try to move the sbl-hypervisor target to function. But missed the EFI_OBJDIR parameter for install/install-debug function. Another problem is we use same EFI_OBJDIR for all uefi build. We now put the EFI_OBJDIR to the build out to avoid this issue. Tracked-On: #3779 Signed-off-by: Yin Fengwei <fengwei.yin@intel.com> Acked-by: Binbin Wu <binbin.wu@intel.com>
1 parent c3eb0d7 commit fcbf9d7

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

Makefile

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ SCENARIO ?= sdc
1616
O ?= build
1717
ROOT_OUT := $(shell mkdir -p $(O);cd $(O);pwd)
1818
HV_OUT := $(ROOT_OUT)/hypervisor
19-
EFI_OUT := $(ROOT_OUT)/misc/efi-stub
19+
EFI_OUT := misc/efi-stub
2020
DM_OUT := $(ROOT_OUT)/devicemodel
2121
TOOLS_OUT := $(ROOT_OUT)/misc/tools
2222
DOC_OUT := $(ROOT_OUT)/doc
@@ -55,21 +55,21 @@ define build_acrn
5555
$(MAKE) -C $(T)/hypervisor HV_OBJDIR=$(HV_OUT)-$(1)/$(2) BOARD=$(2) FIRMWARE=$(1) SCENARIO=$(4) RELEASE=$(RELEASE)
5656
echo "building hypervisor as EFI executable..."
5757
@if [ "$(1)" == "uefi" ]; then \
58-
$(MAKE) -C $(T)/misc/efi-stub HV_OBJDIR=$(HV_OUT)-$(1)/$(2) SCENARIO=$(4) EFI_OBJDIR=$(EFI_OUT); \
58+
$(MAKE) -C $(T)/misc/efi-stub HV_OBJDIR=$(HV_OUT)-$(1)/$(2) SCENARIO=$(4) EFI_OBJDIR=$(HV_OUT)-$(1)/$(2)/$(EFI_OUT); \
5959
fi
6060
endef
6161
6262
define install_acrn
6363
$(MAKE) -C $(T)/hypervisor HV_OBJDIR=$(HV_OUT)-$(1)/$(2) BOARD=$(2) FIRMWARE=$(1) SCENARIO=$(3) RELEASE=$(RELEASE) install
6464
@if [ "$(1)" == "uefi" ]; then \
65-
$(MAKE) -C $(T)/misc/efi-stub HV_OBJDIR=$(HV_OUT)-$(1)/$(2) BOARD=$(2) FIRMWARE=$(1) SCENARIO=$(3) RELEASE=$(RELEASE) install; \
65+
$(MAKE) -C $(T)/misc/efi-stub HV_OBJDIR=$(HV_OUT)-$(1)/$(2) BOARD=$(2) FIRMWARE=$(1) SCENARIO=$(3) RELEASE=$(RELEASE) EFI_OBJDIR=$(HV_OUT)-$(1)/$(2)/$(EFI_OUT) install; \
6666
fi
6767
endef
6868
6969
define install_acrn_debug
7070
$(MAKE) -C $(T)/hypervisor HV_OBJDIR=$(HV_OUT)-$(1)/$(2) BOARD=$(2) FIRMWARE=$(1) SCENARIO=$(3) RELEASE=$(RELEASE) install-debug
7171
@if [ "$(1)" == "uefi" ]; then \
72-
$(MAKE) -C $(T)/misc/efi-stub HV_OBJDIR=$(HV_OUT)-$(1)/$(2) BOARD=$(2) FIRMWARE=$(1) SCENARIO=$(3) RELEASE=$(RELEASE) install-debug; \
72+
$(MAKE) -C $(T)/misc/efi-stub HV_OBJDIR=$(HV_OUT)-$(1)/$(2) BOARD=$(2) FIRMWARE=$(1) SCENARIO=$(3) RELEASE=$(RELEASE) EFI_OBJDIR=$(HV_OUT)-$(1)/$(2)/$(EFI_OUT) install-debug; \
7373
fi
7474
endef
7575
@@ -90,7 +90,7 @@ hypervisor:
9090
BOARD_FILE=$(BOARD_FILE) SCENARIO_FILE=$(SCENARIO_FILE)
9191
ifeq ($(FIRMWARE),uefi)
9292
echo "building hypervisor as EFI executable..."
93-
$(MAKE) -C $(T)/misc/efi-stub HV_OBJDIR=$(HV_OUT) SCENARIO=$(SCENARIO) EFI_OBJDIR=$(EFI_OUT)
93+
$(MAKE) -C $(T)/misc/efi-stub HV_OBJDIR=$(HV_OUT) SCENARIO=$(SCENARIO) EFI_OBJDIR=$(HV_OUT)/$(EFI_OUT)
9494
endif
9595
9696
@@ -117,13 +117,13 @@ install: hypervisor-install devicemodel-install tools-install
117117
hypervisor-install:
118118
$(MAKE) -C $(T)/hypervisor HV_OBJDIR=$(HV_OUT) BOARD=$(BOARD) FIRMWARE=$(FIRMWARE) SCENARIO=$(SCENARIO) RELEASE=$(RELEASE) install
119119
ifeq ($(FIRMWARE),uefi)
120-
$(MAKE) -C $(T)/misc/efi-stub HV_OBJDIR=$(HV_OUT) BOARD=$(BOARD) FIRMWARE=$(FIRMWARE) SCENARIO=$(SCENARIO) EFI_OBJDIR=$(EFI_OUT) all install
120+
$(MAKE) -C $(T)/misc/efi-stub HV_OBJDIR=$(HV_OUT) BOARD=$(BOARD) FIRMWARE=$(FIRMWARE) SCENARIO=$(SCENARIO) EFI_OBJDIR=$(HV_OUT)/$(EFI_OUT) all install
121121
endif
122122
123123
hypervisor-install-debug:
124124
$(MAKE) -C $(T)/hypervisor HV_OBJDIR=$(HV_OUT) BOARD=$(BOARD) FIRMWARE=$(FIRMWARE) SCENARIO=$(SCENARIO) RELEASE=$(RELEASE) install-debug
125125
ifeq ($(FIRMWARE),uefi)
126-
$(MAKE) -C $(T)/misc/efi-stub HV_OBJDIR=$(HV_OUT) BOARD=$(BOARD) FIRMWARE=$(FIRMWARE) SCENARIO=$(SCENARIO) EFI_OBJDIR=$(EFI_OUT) all install-debug
126+
$(MAKE) -C $(T)/misc/efi-stub HV_OBJDIR=$(HV_OUT) BOARD=$(BOARD) FIRMWARE=$(FIRMWARE) SCENARIO=$(SCENARIO) EFI_OBJDIR=$(HV_OUT)/$(EFI_OUT) all install-debug
127127
endif
128128
129129
apl-mrb-sbl-sdc:

0 commit comments

Comments
 (0)