Skip to content
This repository has been archived by the owner on Jan 19, 2018. It is now read-only.

do not create symlink if source doesn't exist #368

Merged
merged 1 commit into from
Nov 4, 2015
Merged

do not create symlink if source doesn't exist #368

merged 1 commit into from
Nov 4, 2015

Conversation

kadel
Copy link
Collaborator

@kadel kadel commented Oct 29, 2015

create symlink for /etc/kubernetes only if /host/etc/kubernetes exists, so we don't end up with invalid symlink

@vpavlin
Copy link
Contributor

vpavlin commented Oct 29, 2015

LGTM

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling b3809f2 on kadel:fix-etc-kubernetes-symlink into 0c750d5 on projectatomic:master.

1 similar comment
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling b3809f2 on kadel:fix-etc-kubernetes-symlink into 0c750d5 on projectatomic:master.

@dustymabe
Copy link
Contributor

Since this was opened against master branch we'll look at it more closely once the cdk branch is merged.

@dustymabe
Copy link
Contributor

hey @kadel. This looks good except for one thing.. can you change the os.path.exists(kube_conf_path) to os.path.lexists. see the comment for more info: #193 (comment)

@dustymabe
Copy link
Contributor

@kadel actually nevermind. Looks good like it is. If we never create the symlink in the first place (if the target doesn't exist) then there is no reason to use lexists().

@dustymabe
Copy link
Contributor

will merge after beta branch is merged tomorrow.

dustymabe added a commit that referenced this pull request Nov 4, 2015
do not create symlink if source doesn't exist
@dustymabe dustymabe merged commit b408831 into projectatomic:master Nov 4, 2015
@kadel kadel deleted the fix-etc-kubernetes-symlink branch November 12, 2015 08:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants