Skip to content
This repository has been archived by the owner on Jan 19, 2018. It is now read-only.

Allow providing default provider with Nulecule file. #492

Closed
wants to merge 1 commit into from

Conversation

rtnpro
Copy link
Contributor

@rtnpro rtnpro commented Jan 11, 2016

This allows specifying a defaultprovider for a Nulecule app in the spec file in the metadata section:

metadata:
  name: Hello Apache App
  appversion: 0.0.1
  description: Atomic app for deploying a really basic Apache HTTP server
  defaultprovider: docker
...

In case you don't have provider specified in the [general] section of your answers.conf file, we first look for metadata.defaultprovider in Nulecule spec file. If no default provider is specified in
Nulecule metadata, we'll default to lib.constants.DEFAULT_PROVIDER for the provider, which is, kubernetes.

Fixes #378

@cdrage
Copy link
Member

cdrage commented Jan 11, 2016

Looks like a test failed :(

Otherwise, it looks good to me.

What's the format again @rtnpro ? We add "defaultprovider" to the meta-data right? We may need a doc for this somewhere. Do we need to update the Nulecule spec too?

@rtnpro
Copy link
Contributor Author

rtnpro commented Jan 19, 2016

Obsoleted by #522

@rtnpro rtnpro closed this Jan 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants