Some hygeine so Travis tests can pass #113
Conversation
Currently, running the tests on master on Travis for this gem fail with two distinct errors: 1. `ActionView::Template::Error: Autoprefixer doesn’t support Node v8.12.0. Update it.` - 9 tests fail with this issue. 2. `NoMethodError: undefined method `search_state_class' for #<ActionView::TestCase::TestController:0x00000000094b15a0>` - 2 tests fail with this issue. Additionally, there are some warnings about gems being found in multiple sources: ``` Warning: the gem 'bindex' was found in multiple sources. Installed from: https://rubygems.org/ Also found in: * http://rubygems.org/ You should add a source requirement to restrict this gem to your preferred source. ``` This PR fixes those errors by: 1) Updating the TRavis config to use Node 12 2) Updating the render_constraints_override spec to work with with changes introuced in Blacklight 7.8.0, by commmit projectblacklight/blacklight@c11db26 It eliminates the multiple source gem warnings by updating updating the rubygems url to https.
|
One of the three builds failed because SolrWrapper timed out on download. Could someone with travis permissions try re-running this build? https://travis-ci.org/github/projectblacklight/blacklight_advanced_search/jobs/729714069 |
.travis.yml
Outdated
| @@ -1,6 +1,9 @@ | |||
| notifications: | |||
| email: false | |||
|
|
|||
| before_install: | |||
| nvm install 12 | |||
There was a problem hiding this comment.
In other projects we've used the xenial distribution on travis, which has Node 12.18.2 already.
Have you tried that or would you consider using that as opposed to updating node as part of the build?
There was a problem hiding this comment.
@jkeck Happy to try a newer distro. I do note that core Blacklight uses bionic.
https://github.com/projectblacklight/blacklight/blob/master/.travis.yml#L1
Is there a specific preference for xenial for this, or should I match core BL?
There was a problem hiding this comment.
I'd say +1 to bionic which should give you the updated node automagically.
There was a problem hiding this comment.
Ah, I hadn't noticed that we weren't even defining a dist. If Bionic gives us the right node, then 👍.
There was a problem hiding this comment.
@jkeck @mejackreed Bionic work great. Thanks!
Currently, running the tests on master on Travis for this gem fail with two distinct errors:
ActionView::Template::Error: Autoprefixer doesn’t support Node v8.12.0. Update it.- 9 tests fail with this issue.NoMethodError: undefined method 'search_state_class' for #<ActionView::TestCase::TestController:0x00000000094b15a0>- 2 tests fail with this issue.Additionally, there are some warnings about gems being found in multiple sources:
This PR fixes those errors by:
It eliminates the multiple source gem warnings by updating updating the rubygems url to https.