Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklight.modal is undefined when using Blacklight 8 #231

Closed
jcoyne opened this issue Mar 3, 2023 · 5 comments
Closed

Blacklight.modal is undefined when using Blacklight 8 #231

jcoyne opened this issue Mar 3, 2023 · 5 comments
Assignees

Comments

@jcoyne
Copy link
Member

jcoyne commented Mar 3, 2023

$(Blacklight.modal.modalSelector).on('shown.bs.modal', function() {

$(Blacklight.modal.modalSelector).on('shown.bs.modal', function() {

It should use Blacklight.Modal.modalSelector instead

@jcoyne jcoyne transferred this issue from projectblacklight/spotlight Mar 3, 2023
@jcoyne jcoyne self-assigned this Mar 3, 2023
@saffeullah
Copy link

On the project I am working, we have blacklight (8.0.0) and blacklight_range_limit (8.3.0). The issue is that blacklight range plugin doesnt seem to work. Is there any fix?
image

@jcoyne
Copy link
Member Author

jcoyne commented Apr 17, 2024

@saffeullah blacklight_range_limit is not compatible with Blacklight 8.

@saffeullah
Copy link

@saffeullah blacklight_range_limit is not compatible with Blacklight 8.

Thanks for replying. Is there any temporary fix? Or some other way(other plugin) to get the same functionality?

@jcoyne
Copy link
Member Author

jcoyne commented Apr 17, 2024

I just don't think that anyone has done the work to make this compatible yet.

@jrochkind
Copy link
Member

Not sure what fixed this, but I believe it is no longer applicable on main branch, and forthcoming 9.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants