New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calico-typha pods - allow Cluster Autoscaler to evict #2235

Merged
merged 2 commits into from Oct 16, 2018

Conversation

Projects
None yet
4 participants
@markfermor
Copy link
Contributor

markfermor commented Oct 16, 2018

Description

Type- bug fix/feature

On our GKE cluster I was looking into reasons why the CA wasn't taking effect against some nodes. It looks as though the calico-typha pods could be one reason. Once I deleted one of the typha pods from a node and let it run on a different node in the cluster, the node I was working on then became a valid candidate for scale down.

Unfortunately because we run on GKE I can't see the logs for the CA to 100% confirm this, but it does seem the most likely. As the pods have local node storage attached (at least they do in GKE) then I also added the safe-to-evict annotation as well as added a PDB.

This might not be right or useful as I'm mostly looking at what in GKE. GKE also runs pods for Typha autoscaling (calico-typha-vertical-autoscaler and calico-typha-horizontal-autoscaler) which also probably require the same settings to be applied.

Perhaps this is something I should feedback directly to GKE rather than via this PR?

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Typha now has a PodDisruptionBudget for compatibility with the cluster autoscaler.

@markfermor markfermor requested a review from projectcalico/core-maintainers as a code owner Oct 16, 2018

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Oct 16, 2018

CLA assistant check
All committers have signed the CLA.

@fasaxc

This comment has been minimized.

Copy link
Member

fasaxc commented Oct 16, 2018

@markfermor LGTM, are you able to resolve the CLA issue? Looks like the commits you're pushing come from dockyard-deploy instead of your account?

CC @caseydavenport; looks like we'll want this to be merged into the GKE manifests.

@markfermor markfermor force-pushed the markfermor:calicoTyphaK8sCA branch from 91238d9 to f0d6f53 Oct 16, 2018

@markfermor

This comment has been minimized.

Copy link
Contributor

markfermor commented Oct 16, 2018

@fasaxc sorry yes. Hopefully thats done it

@fasaxc

fasaxc approved these changes Oct 16, 2018

@fasaxc fasaxc merged commit 3fe1dc6 into projectcalico:master Oct 16, 2018

1 check passed

semaphoreci The build passed on Semaphore.
Details

@caseydavenport caseydavenport added this to the Calico v3.4.0 milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment