Built stripped binaries when release #6686
Closed
+19
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marvin-tigera
added
docs-pr-required
caseydavenport
requested changes
Sep 12, 2022
caseydavenport
requested changes
Sep 20, 2022
|
@afshinpaydar-binary is this something you're still planning to work on? |
|
@caseydavenport Could you please take a look at these changes again? |
afshin-deriv
force-pushed
the
afshinpaydar/built_stripped_binaries
branch
from
423d0c9
to
01aa337
Compare
|
/sem-approve |
|
@afshin-deriv Also, I'm afraid we can't accept this PR unless you sign the CLA to make the bot happy. |
hjiawei
reviewed
Mar 2, 2023
afshin-deriv
force-pushed
the
afshinpaydar/built_stripped_binaries
branch
from
3505758
to
9402b9e
Compare
|
/sem-approve |
^ Builds seem to be failing with this error |
rene-dekker
reviewed
Mar 24, 2023
rene-dekker
reviewed
Mar 24, 2023
afshin-deriv
force-pushed
the
afshinpaydar/built_stripped_binaries
branch
from
a8a9704
to
e9e1813
Compare
rene-dekker
reviewed
Apr 5, 2023
Signed-off-by: Afshin Paydar <afshin.paydar@binary.com>
afshin-deriv
force-pushed
the
afshinpaydar/built_stripped_binaries
branch
from
e9e1813
to
2673da1
Compare
|
Is this still in progress? |
marvin-tigera
removed
release-note-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Afshin Paydar afshin.paydar@binary.com
Description
kind/enhancementRelated issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.