Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v3.28] Auto pick #8990: Rebuild flannel-cni-plugin binaries on demand #8993

Conversation

coutinhop
Copy link
Contributor

Cherry pick of #8990 on release-v3.28.

#8990: Rebuild flannel-cni-plugin binaries on demand

Original PR Body below

Do the same for flannel-cni-plugin as #8909 did for containernetworking-plugins, i.e. clone the repo and build using the go-build image from the calico monorepo on-demand.

This is done to remove the tedious step of creating new releases and updating the Makefile with the new version on the flannel-cni-plugin repo.

Description

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

TBD

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

Do the same for flannel-cni-plugin as projectcalico#8909
did for containernetworking-plugins, i.e. clone the repo and build using
the go-build image from the calico monorepo on-demand.

This is done to remove the tedious step of creating new releases and updating
the Makefile with the new version on the flannel-cni-plugin repo.
@coutinhop coutinhop requested a review from a team as a code owner July 8, 2024 21:06
@coutinhop coutinhop added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact labels Jul 8, 2024
@marvin-tigera marvin-tigera added this to the Calico v3.28.1 milestone Jul 8, 2024
@coutinhop coutinhop merged commit 1d5b41f into projectcalico:release-v3.28 Jul 9, 2024
2 checks passed
@coutinhop coutinhop self-assigned this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants