Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

get operator in sync with Contour #464

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Conversation

skriss
Copy link
Member

@skriss skriss commented Nov 1, 2021

Updates operator per Contour changes:

projectcontour/contour#4141
projectcontour/contour#4138
projectcontour/contour#4145

Signed-off-by: Steve Kriss krisss@vmware.com

Updates operator per Contour changes:

projectcontour/contour#4141
projectcontour/contour#4138
projectcontour/contour#4145

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss requested a review from a team as a code owner November 1, 2021 20:41
@skriss skriss requested review from tsaarni and youngnick and removed request for a team November 1, 2021 20:41
@skriss
Copy link
Member Author

skriss commented Nov 1, 2021

Yet another PR that would've failed the upgrade test due to #438 were it not disabled already.

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #464 (51ddbd5) into main (8439647) will decrease coverage by 2.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
- Coverage   80.41%   77.85%   -2.56%     
==========================================
  Files          29       29              
  Lines        2231     2213      -18     
==========================================
- Hits         1794     1723      -71     
- Misses        322      355      +33     
- Partials      115      135      +20     
Impacted Files Coverage Δ
internal/operator/operator.go 77.77% <ø> (+25.92%) ⬆️
internal/objects/clusterrole/cluster_role.go 90.17% <100.00%> (ø)
internal/status/status.go 48.64% <0.00%> (-24.33%) ⬇️
internal/objects/contour/finalizer.go 62.50% <0.00%> (-18.75%) ⬇️
internal/objects/rbac.go 54.76% <0.00%> (-9.53%) ⬇️
internal/controller/controller.go 74.59% <0.00%> (-8.20%) ⬇️
internal/objects/configmap/configmap.go 70.88% <0.00%> (-6.33%) ⬇️
internal/objects/job/job.go 76.52% <0.00%> (-5.22%) ⬇️
internal/objects/contour/contour.go 76.62% <0.00%> (-5.20%) ⬇️
internal/objects/service/service.go 84.34% <0.00%> (-4.35%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8439647...51ddbd5. Read the comment docs.

@stevesloka
Copy link
Member

Yet another PR that would've failed the upgrade test due to #438 were it not disabled already.

Also, yet another set of effort solved by combining the repos. 😢

@stevesloka stevesloka merged commit 2bbc2d3 into projectcontour:main Nov 2, 2021
@skriss skriss deleted the fix branch December 9, 2021 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants