Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1276 permits regex routes in ingressroute #1287

Closed
davecheney opened this issue Aug 1, 2019 · 1 comment · Fixed by #1288
Closed

#1276 permits regex routes in ingressroute #1287

davecheney opened this issue Aug 1, 2019 · 1 comment · Fixed by #1288
Assignees
@davecheney
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
0.15.0

Comments

@davecheney
Copy link
Contributor

As a side effect of #1276 path prefixes in ingressroute can now be regexes. This is not something that is currently permitted and we should make sure people don't rely on it.

Note: We are planning on adding other routing options to Ingressroute, #1075 , but we want to do it in a planned, not accidental, way.
@davecheney davecheney self-assigned this Aug 1, 2019
@davecheney davecheney added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Aug 1, 2019
@davecheney davecheney added this to the 0.15.0 milestone Aug 1, 2019
@davecheney
Copy link
Contributor Author

I'm fixing this now. It is a blocker on 0.14.1

davecheney added a commit to davecheney/contour that referenced this issue Aug 1, 2019
@davecheney
internal/dag: split Route into PrefixRoute and RegexRoute
0c7324a 
Fixes projectcontour#1287

Move the representation of prefix route and regex route out of
internal/envoy and into the DAG. This moves the responsibility for
choosing when to emit a prefix or regex route from the vistors in
internal/contour (via internal/envoy) and into the internal/dag builder.

Signed-off-by: Dave Cheney <dave@cheney.net>
@davecheney davecheney mentioned this issue Aug 1, 2019
Merged
davecheney added a commit that referenced this issue Aug 2, 2019
@davecheney
internal/dag: split Route into PrefixRoute and RegexRoute
3e5dde0 
Fixes #1287

Move the representation of prefix route and regex route out of
internal/envoy and into the DAG. This moves the responsibility for
choosing when to emit a prefix or regex route from the vistors in
internal/contour (via internal/envoy) and into the internal/dag builder.

Signed-off-by: Dave Cheney <dave@cheney.net>
davecheney added a commit to davecheney/contour that referenced this issue Aug 2, 2019
@davecheney
internal/dag: split Route into PrefixRoute and RegexRoute
de28dd6 
Fixes projectcontour#1287

Move the representation of prefix route and regex route out of
internal/envoy and into the DAG. This moves the responsibility for
choosing when to emit a prefix or regex route from the vistors in
internal/contour (via internal/envoy) and into the internal/dag builder.

Signed-off-by: Dave Cheney <dave@cheney.net>
davecheney added a commit that referenced this issue Aug 2, 2019
@davecheney
internal/dag: split Route into PrefixRoute and RegexRoute
988b948 
Fixes #1287

Move the representation of prefix route and regex route out of
internal/envoy and into the DAG. This moves the responsibility for
choosing when to emit a prefix or regex route from the vistors in
internal/contour (via internal/envoy) and into the internal/dag builder.

Signed-off-by: Dave Cheney <dave@cheney.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davecheney davecheney

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

internal/dag: split Route into PrefixRoute and RegexRoute davecheney/contour
1 participant
@davecheney