internal/contour: bind https listener to ingress_https routes #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates projectcontour#104 Create separate http and https route caches. These caches share the same notifier as all routesconfiguration objects are streamed to envoy each update. At the moment the https route cache is empty. Signed-off-by: Dave Cheney <dave@cheney.net>
davecheney
force-pushed
the
issue/104
branch
from
207a06b
to
58c3493
Compare
Fixes projectcontour#104 RDS now publishes routes to http and https caches. LDS now binds the http listener to the RDS https cache, ingress_http, by name, and vice versa for the https listener. This permits RDS to compute different routes for http and https listeners, enabling http to https redirects. Signed-off-by: Dave Cheney <dave@cheney.net>
sunjayBhatia
pushed a commit
that referenced
this pull request
Jan 30, 2023
Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104
RDS now publishes routes to http and https caches. LDS now binds the
http listener to the RDS http cache, ingress_http, by name, and vice
versa for the https listener.
This permits RDS to compute different routes for http and https
listeners, enabling http to https redirects.
Signed-off-by: Dave Cheney dave@cheney.net